From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0CB251FF136 for ; Mon, 23 Mar 2026 15:44:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C9F7A1F3E6; Mon, 23 Mar 2026 15:44:48 +0100 (CET) Date: Mon, 23 Mar 2026 15:44:41 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: Re: [PATCH proxmox-backup v3 5/6] config: move node config into pbs-config, including helper tools To: Christian Ebner , pbs-devel@lists.proxmox.com References: <20260312114208.514373-1-c.ebner@proxmox.com> <20260312114208.514373-8-c.ebner@proxmox.com> In-Reply-To: <20260312114208.514373-8-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1774276817.tcl7n25wkz.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774277038587 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2WHQLB2POWYGQN5FPPBWIRLG5UKVX3RT X-Message-ID-Hash: 2WHQLB2POWYGQN5FPPBWIRLG5UKVX3RT X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On March 12, 2026 12:42 pm, Christian Ebner wrote: > None of the helpers are required in proxmox-backup anymore, all > encapsulated in the pbs-config crate. Keep however the same > `tools::config` module layout. >=20 > Adapt all callsides to use pbs_config::node to interact with the node > config. >=20 > Signed-off-by: Christian Ebner > --- > pbs-config/Cargo.toml | 1 + > pbs-config/src/lib.rs | 2 ++ > {src/config =3D> pbs-config/src}/node.rs | 7 ++++--- > {src =3D> pbs-config/src}/tools/config.rs | 0 > pbs-config/src/tools/mod.rs | 1 + > src/api2/config/remote.rs | 2 +- > src/api2/node/apt.rs | 2 +- > src/api2/node/certificates.rs | 4 ++-- > src/api2/node/config.rs | 8 ++++---- > src/api2/node/subscription.rs | 2 +- > src/bin/proxmox-backup-proxy.rs | 9 ++++----- > src/bin/proxmox-daily-update.rs | 2 +- > src/config/mod.rs | 1 - > src/tools/mod.rs | 1 - > 14 files changed, 22 insertions(+), 20 deletions(-) > rename {src/config =3D> pbs-config/src}/node.rs (89%) > rename {src =3D> pbs-config/src}/tools/config.rs (100%) > create mode 100644 pbs-config/src/tools/mod.rs nit: I think this doesn't make a lot of sense, (pbs-config/)tools/config.rs should probably be renamed to something like pbs-config/key_value.rs or pbs-config/simple.rs ? or even be inlined into node.rs, if we don't expect more such config files to be introduced..