From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C37B11FF13F for ; Thu, 12 Mar 2026 12:20:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C19ED11C52; Thu, 12 Mar 2026 12:20:25 +0100 (CET) Date: Thu, 12 Mar 2026 12:20:16 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: applied: [PATCH proxmox v5 03/13] shared-memory: expose msync to flush in-memory contents to filesystem To: Christian Ebner , pbs-devel@lists.proxmox.com References: <20260311130823.724888-1-c.ebner@proxmox.com> <20260311130823.724888-4-c.ebner@proxmox.com> In-Reply-To: <20260311130823.724888-4-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1773313627.814fm3hk83.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773314383754 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7SJCMYMMHL7AK4D7ZW6UCW5UO4QXKT6U X-Message-ID-Hash: 7SJCMYMMHL7AK4D7ZW6UCW5UO4QXKT6U X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On March 11, 2026 2:07 pm, Christian Ebner wrote: > Exposes proxmox_sys::mmap::Mmap::msync() to allow flushing all > in-memory contents to the underlying mmapped file. Without this, it > is not guaranteed that contents are persisted until unmapping, which > can lead to data loss in case of host crashes or OOM situations. >=20 > Signed-off-by: Christian Ebner > --- > proxmox-shared-memory/src/lib.rs | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/proxmox-shared-memory/src/lib.rs b/proxmox-shared-memory/src= /lib.rs > index da057366..cd67c63a 100644 > --- a/proxmox-shared-memory/src/lib.rs > +++ b/proxmox-shared-memory/src/lib.rs > @@ -12,7 +12,7 @@ use std::path::Path; > use anyhow::{bail, format_err, Error}; > use nix::errno::Errno; > use nix::fcntl::OFlag; > -use nix::sys::mman::{MapFlags, ProtFlags}; > +use nix::sys::mman::{MapFlags, MsFlags, ProtFlags}; > use nix::sys::stat::Mode; > =20 > use proxmox_sys::error::SysError; > @@ -230,6 +230,11 @@ impl SharedMemory { > pub fn data_mut(&mut self) -> &mut T { > &mut self.mmap[0] > } > + > + /// Flush all in-memory contents to the backing file. > + pub fn msync(&self, flags: MsFlags) -> Result<(), Error> { > + self.mmap.msync(flags).map_err(Into::into) > + } > } > =20 > /// Helper to initialize nested data > --=20 > 2.47.3 >=20 >=20 >=20 >=20 >=20 >=20