From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 720E31FF13F for ; Thu, 12 Mar 2026 12:20:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CBB2E11BD3; Thu, 12 Mar 2026 12:20:20 +0100 (CET) Date: Thu, 12 Mar 2026 12:20:11 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: applied: [PATCH proxmox v5 01/13] proxmox-sys: expose msync to flush mmapped contents to filesystem To: Christian Ebner , pbs-devel@lists.proxmox.com References: <20260311130823.724888-1-c.ebner@proxmox.com> <20260311130823.724888-2-c.ebner@proxmox.com> In-Reply-To: <20260311130823.724888-2-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1773313584.uep7z3ypa9.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773314379171 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.012 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UHGDWEG73GYLWP3UU2BD5IZM7LUP7DPN X-Message-ID-Hash: UHGDWEG73GYLWP3UU2BD5IZM7LUP7DPN X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: and bumped On March 11, 2026 2:07 pm, Christian Ebner wrote: > Allows to flush all in-memory contents of the mmapped file back to > the filesystem using msync [0] given the semantics provided via the > `MS_*` flags. > Without this the contents are not guaranteed to be persisted to the > backing file until unmapped, which could lead to data loss on system > crash or OOM situations. >=20 > [0] https://man7.org/linux/man-pages/man2/msync.2.html >=20 > Signed-off-by: Christian Ebner > --- > proxmox-sys/src/mmap.rs | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/proxmox-sys/src/mmap.rs b/proxmox-sys/src/mmap.rs > index 8b8ad8a6..e15ca1db 100644 > --- a/proxmox-sys/src/mmap.rs > +++ b/proxmox-sys/src/mmap.rs > @@ -56,6 +56,18 @@ impl Mmap { > len: count, > }) > } > + > + /// Flush all in-memory contents to the backing file. > + pub fn msync(&self, flags: mman::MsFlags) -> io::Result<()> { > + unsafe { > + mman::msync( > + self.data.cast::(), > + self.len * mem::size_of::(), > + flags, > + ) > + } > + .map_err(SysError::into_io_error) > + } > } > =20 > impl std::ops::Deref for Mmap { > --=20 > 2.47.3 >=20 >=20 >=20 >=20 >=20 >=20