From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 512661FF13C for ; Thu, 05 Mar 2026 09:50:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3BE5C1D727; Thu, 5 Mar 2026 09:52:01 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com, Christian Ebner Subject: applied: [PATCH proxmox-backup] chunk store: s3: mute warning on overwrite empty chunk in local cache Date: Thu, 5 Mar 2026 09:50:42 +0100 Message-ID: <177270064027.249592.16258482045291452957.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260304103600.263896-1-c.ebner@proxmox.com> References: <20260304103600.263896-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772700660041 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.018 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.703 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1.386 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FEPIL42HQ5VXEZAVBEYTWDNLGMD2ADU6 X-Message-ID-Hash: FEPIL42HQ5VXEZAVBEYTWDNLGMD2ADU6 X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 04 Mar 2026 11:36:00 +0100, Christian Ebner wrote: > For regular datastores overwriting chunks which have 0 size is > unexpected and cannot happen under regular operation. For datastores > backed by an S3 object storage, this is however expected as regular > operation if the cache reaches its capacity, since chunks get evicted > from the cache by leaving an empty file as chunk marker behind. > > While the warning is benign, it causes false alerts in the task logs. > Therefore, silence the warning if the chunk insert overwriting the > file happens via the local datastore cache. > > [...] Applied, thanks! Might be something to consider when refactoring the whole datastore/chunkstore interaction with a proper locked wrapper and integrating the backend - this could then be derived from the backend? [1/1] chunk store: s3: mute warning on overwrite empty chunk in local cache commit: fa9fa9b82d768b912987f78df313cea6fd145078 Best regards, -- Fabian Grünbichler