From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com,
Samuel Rufinatscha <s.rufinatscha@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup v6 0/4] datastore: remove config reload on hot path
Date: Wed, 14 Jan 2026 10:54:13 +0100 [thread overview]
Message-ID: <176838445074.321183.1887219364945317856.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260105141615.242463-1-s.rufinatscha@proxmox.com>
On Mon, 05 Jan 2026 15:16:10 +0100, Samuel Rufinatscha wrote:
> this series reduces CPU time in datastore lookups by avoiding repeated
> datastore.cfg reads/parses in both `lookup_datastore()` and
> `DataStore::Drop`. It also adds a TTL so manual config edits are
> noticed without reintroducing hashing on every request.
>
> While investigating #6049 [1], cargo-flamegraph [2] showed hotspots
> during repeated `/status` calls in `lookup_datastore()` and in `Drop`,
> dominated by `pbs_config::datastore::config()` (config parse).
>
> [...]
Applied with some rewording of commit messages to make them less
verbose/boiler-platey, thanks!
[1/4] config: enable config version cache for datastore
commit: d14b7469a72f4265bcc1727a1274b207bc201be0
[2/4] partial fix #6049: datastore: impl ConfigVersionCache fast path for lookups
commit: be6d251e4483474754cdc5f6d12f2674e22fa132
[3/4] partial fix #6049: datastore: use config fast-path in Drop
commit: 584fa961909c32565046c39f95485273c0a8cba5
[4/4] partial fix #6049: datastore: add TTL fallback to catch manual config edits
commit: 07ab13e5aaf1d6b790234d5238c1c3668c56c22e
Best regards,
--
Fabian Grünbichler <f.gruenbichler@proxmox.com>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2026-01-14 9:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 14:16 [pbs-devel] [PATCH proxmox-backup v6 0/4] datastore: remove config reload on hot path Samuel Rufinatscha
2026-01-05 14:16 ` [pbs-devel] [PATCH proxmox-backup v6 1/4] config: enable config version cache for datastore Samuel Rufinatscha
2026-01-05 14:16 ` [pbs-devel] [PATCH proxmox-backup v6 2/4] partial fix #6049: datastore: impl ConfigVersionCache fast path for lookups Samuel Rufinatscha
2026-01-05 14:16 ` [pbs-devel] [PATCH proxmox-backup v6 3/4] partial fix #6049: datastore: use config fast-path in Drop Samuel Rufinatscha
2026-01-05 14:16 ` [pbs-devel] [PATCH proxmox-backup v6 4/4] partial fix #6049: datastore: add TTL fallback to catch manual config edits Samuel Rufinatscha
2026-01-14 9:54 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176838445074.321183.1887219364945317856.b4-ty@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.rufinatscha@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox