From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dietmar@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id E75826AD11
 for <pbs-devel@lists.proxmox.com>; Wed, 17 Feb 2021 09:50:56 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id DA69B1F8F9
 for <pbs-devel@lists.proxmox.com>; Wed, 17 Feb 2021 09:50:56 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 74CB01F8EC
 for <pbs-devel@lists.proxmox.com>; Wed, 17 Feb 2021 09:50:56 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4452942D51
 for <pbs-devel@lists.proxmox.com>; Wed, 17 Feb 2021 09:50:56 +0100 (CET)
Date: Wed, 17 Feb 2021 09:50:12 +0100 (CET)
From: Dietmar Maurer <dietmar@proxmox.com>
To: Stefan Reiter <s.reiter@proxmox.com>,
 Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
Message-ID: <1764987944.3055.1613551813740@webmail.proxmox.com>
In-Reply-To: <62011626-da51-ed12-d405-4274eb8ab71d@proxmox.com>
References: <20210216170710.31767-1-s.reiter@proxmox.com>
 <20210216170710.31767-10-s.reiter@proxmox.com>
 <1667517314.3028.1613544553823@webmail.proxmox.com>
 <62011626-da51-ed12-d405-4274eb8ab71d@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.4-Rev16
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.122 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup 09/22] client: extract common
 functions to proxmox_client_tools module
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 17 Feb 2021 08:50:56 -0000


> On 02/17/2021 8:58 AM Stefan Reiter <s.reiter@proxmox.com> wrote:
> 
>  
> On 17/02/2021 07:49, Dietmar Maurer wrote:
> > I thought we can put all client related code into src/client/
> > 
> > So why starting another lib inside src/bin/proxmox_client_tools/?
> > 
> 
> Why was (part of) it initially in src/bin/proxmox_backup_client then and 
> not src/client/ ? I thought it was to seperate the "binary-specific" 
> client code from more generic client code (such as used in pull or the 
> QEMU library as well).

Ok, but why do you move cli functions like:

fn paper_key()
fn show_key()


Those belongs to proxmox-backup-client - or do we reuse them somewhere?