From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id F07101FF17A for ; Tue, 11 Nov 2025 13:08:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 146C383CE; Tue, 11 Nov 2025 13:09:05 +0100 (CET) Date: Tue, 11 Nov 2025 13:08:57 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20251029160103.241780-1-h.laimer@proxmox.com> <20251029160103.241780-2-h.laimer@proxmox.com> In-Reply-To: <20251029160103.241780-2-h.laimer@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1762862146.t8vqgbe2um.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762862917854 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox v2 1/1] pbs-api-types: add 'unmount-on-done' field to sync job config X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On October 29, 2025 5:00 pm, Hannes Laimer wrote: > Tested-by: Robert Obkircher > Signed-off-by: Hannes Laimer > --- > pbs-api-types/src/jobs.rs | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/pbs-api-types/src/jobs.rs b/pbs-api-types/src/jobs.rs > index 3eb61cde..3284a4c8 100644 > --- a/pbs-api-types/src/jobs.rs > +++ b/pbs-api-types/src/jobs.rs > @@ -538,6 +538,8 @@ pub const SYNC_VERIFIED_ONLY_SCHEMA: Schema = > BooleanSchema::new("Only synchronize verified backup snapshots, exclude others.").schema(); > pub const RUN_SYNC_ON_MOUNT_SCHEMA: Schema = > BooleanSchema::new("Run this job when a relevant datastore is mounted.").schema(); > +pub const UNMOUNT_ON_SYNC_DONE_SCHEMA: Schema = > + BooleanSchema::new("Unmount involved removable datastore after sync job finishes.").schema(); > > #[api( > properties: { > @@ -609,6 +611,10 @@ pub const RUN_SYNC_ON_MOUNT_SCHEMA: Schema = > schema: RUN_SYNC_ON_MOUNT_SCHEMA, > optional: true, > }, > + "unmount-on-done": { > + schema: UNMOUNT_ON_SYNC_DONE_SCHEMA, > + optional: true, > + }, > "sync-direction": { > type: SyncDirection, > optional: true, > @@ -655,6 +661,8 @@ pub struct SyncJobConfig { > #[serde(skip_serializing_if = "Option::is_none")] > pub run_on_mount: Option, > #[serde(skip_serializing_if = "Option::is_none")] > + pub unmount_on_done: Option, could we combine these two into a property string/option, to make it more explicit that the "unmount when done" part is only valid/relevant for the "synced-cause-of-mount" execution? > + #[serde(skip_serializing_if = "Option::is_none")] > pub sync_direction: Option, > } > > -- > 2.47.3 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel