From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 38CC81FF17A for ; Tue, 11 Nov 2025 11:13:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D1C7D4017; Tue, 11 Nov 2025 11:13:51 +0100 (CET) Date: Tue, 11 Nov 2025 11:13:14 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20251104131934.449757-1-c.ebner@proxmox.com> <20251104131934.449757-3-c.ebner@proxmox.com> In-Reply-To: <20251104131934.449757-3-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1762855821.u7yqy491qm.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762855974923 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] api: datastore: wait for active operations to clear before s3 refresh X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" this one looks mostly okay, but as we actually want the exact same semantics as with unmounting, we could refactor the whole helper there to do all of the logic? e.g., have a `wait_until_operations_done_and_ensure_maintenance_mode` helper that calls a callback (that does the actual unmounting/refreshing) On November 4, 2025 2:19 pm, Christian Ebner wrote: > Currently, the s3 refresh does not take into consideration already > ongoing active operations, only blocking new ones. > This will however lead to inconsistencies if there are ongoing read > or write operations. Therefore, actively wait for ongoing operatioins > to complete before running the actual refresh. > If an abort was requested while waiting, clear the maintenance mode as > well. > > Signed-off-by: Christian Ebner > --- > src/api2/admin/datastore.rs | 21 ++++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs > index 00110119f..a43aad610 100644 > --- a/src/api2/admin/datastore.rs > +++ b/src/api2/admin/datastore.rs > @@ -2756,7 +2756,26 @@ pub fn s3_refresh(store: String, rpcenv: &mut dyn RpcEnvironment) -> Result Some(store.clone()), > auth_id.to_string(), > to_stdout, > - move |_worker| { > + move |worker| { > + let mut active_operations = task_tracking::get_active_operations(&store)?; > + let mut old_status = String::new(); > + while active_operations.read + active_operations.write > 0 { > + if worker.abort_requested() { > + maintenance_mode(&store, None).context("failed to clear maintenance mode")?; > + bail!("aborted by user"); > + } > + let status = format!( > + "cannot refresh contents, {} active read and {} active write operations", > + active_operations.read, active_operations.write > + ); > + if status != old_status { > + info!("{status}"); > + old_status = status; > + } > + std::thread::sleep(std::time::Duration::from_secs(1)); > + active_operations = task_tracking::get_active_operations(&store)?; > + } > + > proxmox_async::runtime::block_on(datastore.s3_refresh())?; > > maintenance_mode(&store, None).context("failed to clear maintenance mode") > -- > 2.47.3 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel