From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BD14E1FF16B for ; Fri, 7 Nov 2025 16:47:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8BB1016F82; Fri, 7 Nov 2025 16:48:35 +0100 (CET) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, Christian Ebner Date: Fri, 7 Nov 2025 16:45:56 +0100 Message-ID: <176253035292.3494069.12188877610255234903.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251106171358.865503-1-c.ebner@proxmox.com> References: <20251106171358.865503-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762530462625 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] partially-applied: [PATCH proxmox-backup v2 0/3] fix GC atime update race window X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On Thu, 06 Nov 2025 18:13:55 +0100, Christian Ebner wrote: > Sweeping of unused chunks during garbage collection checks their > atime to distinguish between chunks being in-use and chunks no > longer being used. While garbage collection does lock the chunk > store by guarding its mutex before reading file stats and deleting > unused chunks, the conditional touch did not do this before updating > the chunks atime (thereby also checking the presence). > > [...] Applied the first two patches, thanks! For the third one I would rather like an actual review from Fabian, especially w.r.t. adding the callback. [1/3] chunk store: limit scope for atime update helper methods commit: 5799bcda53220c78ff45a44e5b58582a0fac2e83 [2/3] chunk store: fix race window between chunk stat and gc cleanup commit: d45077366778c20293901b5e3ef36725cf123f88 [3/3] datastore: insert chunk marker and touch bad chunks in locked context SKIPPED _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel