From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8CD251FF15E for ; Mon, 27 Oct 2025 15:10:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7F72E706D; Mon, 27 Oct 2025 15:10:42 +0100 (CET) Date: Mon, 27 Oct 2025 15:10:35 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20251015164008.975591-1-c.ebner@proxmox.com> <20251015164008.975591-2-c.ebner@proxmox.com> In-Reply-To: <20251015164008.975591-2-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1761574009.v0p77e4aa7.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761574227535 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox v3 1/2] s3-client: add exponential backoff time for upload retries X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On October 15, 2025 6:39 pm, Christian Ebner wrote: > With the main purpose to backoff some time in case of concurrent > conditional uploads with the If-None-Match header is set. For these, > the upload will fail with http status code 409 as stated in [0]. The > backoff time will increase the time window for the already ongoing > upload to finish. > > [0] https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObject.html#API_PutObject_RequestSyntax > > Signed-off-by: Christian Ebner > --- > proxmox-s3-client/src/client.rs | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/proxmox-s3-client/src/client.rs b/proxmox-s3-client/src/client.rs > index abb35f2f..4ebd8c4b 100644 > --- a/proxmox-s3-client/src/client.rs > +++ b/proxmox-s3-client/src/client.rs > @@ -715,6 +715,10 @@ impl S3Client { > .max(S3_HTTP_REQUEST_TIMEOUT.as_secs()); > let timeout = Some(Duration::from_secs(timeout_secs)); > for retry in 0..MAX_S3_UPLOAD_RETRY { > + if retry > 0 { > + let backoff_secs = S3_HTTP_REQUEST_RETRY_BACKOFF_DEFAULT * 3_u32.pow(retry as u32); > + tokio::time::sleep(backoff_secs).await; > + } should we move this to the PubObjectResponse::NeedsRetry handling, to ensure the exponential backoff only triggers for that particular error path? or do you think other generic error conditions would also benefit from it? > let body = Body::from(object_data.clone()); > match self > .put_object(object_key.clone(), body, timeout, replace) > -- > 2.47.3 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel