From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH v2 proxmox 1/4] pbs api types: extend garbage collection status by cache stats
Date: Wed, 04 Jun 2025 15:01:21 +0200 [thread overview]
Message-ID: <1749041919.x0tau2fhvw.astroid@yuna.none> (raw)
In-Reply-To: <20250519055518.3747-2-c.ebner@proxmox.com>
On May 19, 2025 7:55 am, Christian Ebner wrote:
> Add the number of cache hits and cache misses encountered during
> phase 1 of garbage collection in order to display this information
> in the garbage collection task log summary.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> changes since version 1:
> - no changes
>
> pbs-api-types/src/datastore.rs | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
> index 5bd953ac..4fb1eb80 100644
> --- a/pbs-api-types/src/datastore.rs
> +++ b/pbs-api-types/src/datastore.rs
> @@ -1459,6 +1459,10 @@ pub struct GarbageCollectionStatus {
> pub removed_bad: usize,
> /// Number of chunks still marked as .bad after garbage collection.
> pub still_bad: usize,
> + /// Number of atime update cache hits
> + pub cache_hits: usize,
> + /// Number of atime update cache misses
> + pub cache_misses: usize,
this breaks parsing the GC status file on upgrades:
Jun 04 14:58:00 yuna proxmox-backup-proxy[1285990]: error reading gc-status: missing field `cache-hits` at line 1 column 269
reverting the dedup factor to the default of 1..
do we want to mark them as optional?
> }
>
> #[api(
> --
> 2.39.5
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-06-04 13:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 5:55 [pbs-devel] [PATCH v2 proxmox-backup 0/4] add GC cache stats and fix disabled state Christian Ebner
2025-05-19 5:55 ` [pbs-devel] [PATCH v2 proxmox 1/4] pbs api types: extend garbage collection status by cache stats Christian Ebner
2025-06-04 13:01 ` Fabian Grünbichler [this message]
2025-06-04 13:15 ` Christian Ebner
2025-05-19 5:55 ` [pbs-devel] [PATCH v2 proxmox-backup 2/4] tools: lru cache: document limitations for cache capacity Christian Ebner
2025-05-19 5:55 ` [pbs-devel] [PATCH v2 proxmox-backup 3/4] garbage collection: bypass cache if gc-cache-capacity is 0 Christian Ebner
2025-05-19 5:55 ` [pbs-devel] [PATCH v2 proxmox-backup 4/4] garbage collection: track chunk cache stats and show in task log Christian Ebner
2025-06-04 13:13 ` [pbs-devel] partially-applied: (subset) [PATCH v2 proxmox-backup 0/4] add GC cache stats and fix disabled state Fabian Grünbichler
2025-06-04 15:36 ` [pbs-devel] superseded: " Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1749041919.x0tau2fhvw.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox