From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id EC8181FF172
for <inbox@lore.proxmox.com>; Wed, 16 Apr 2025 14:57:00 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 53FA536E29;
Wed, 16 Apr 2025 14:56:56 +0200 (CEST)
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com,
Dominik Csapak <d.csapak@proxmox.com>
Date: Wed, 16 Apr 2025 14:56:17 +0200
Message-Id: <174480781987.1433073.861145140295426472.b4-ty@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250415114043.2389789-1-d.csapak@proxmox.com>
References: <20250415114043.2389789-1-d.csapak@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.036 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pbs-devel] applied: [PATCH proxmox-backup] tape: wait for
calibration of LTO-9 tapes
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
On Tue, 15 Apr 2025 13:40:43 +0200, Dominik Csapak wrote:
> Since LTO-9, initial loading of tapes into a drive can block up to 2
> hours according to the spec. In case we run into a ready check timeout,
> query the drive, and increase the timeout to 2 hours and 5 minutes if
> it's calibrating (5 minutes headroom).
>
>
Applied, thanks! I extended the commit message with the follow-up info you
provided and also referenced the commit that implemented the longer
timeout for the format procedure.
btw. there is a theoretical case where one could call this method with a
timeout greater than your fallback and the tape needing even longer than
normal, in that case we would do an extra checking round before decreasing
the timeout and then bail on the next round, so not even problematic, just
might be a bit odd on debugging in the very unlikely case this happens in
the first place. That said, a doc-comment for the method and maybe even a
check if the original timeout parameter is already longer than 2h5m would
not exactly hurt and clarify this. But if that makes even sense it really
can be done as a follow up.
[1/1] tape: wait for calibration of LTO-9 tapes
commit: 07a21616c28a09efb6039e79163b9c4ac8610565
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel