From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id CBD371FF172
for <inbox@lore.proxmox.com>; Wed, 16 Apr 2025 11:37:56 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 16DEC31BB1;
Wed, 16 Apr 2025 11:37:55 +0200 (CEST)
Date: Wed, 16 Apr 2025 11:37:18 +0200
From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
References: <20250416085644.41749-1-s.sterz@proxmox.com>
In-Reply-To: <20250416085644.41749-1-s.sterz@proxmox.com>
MIME-Version: 1.0
User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid)
Message-Id: <1744796145.vk4lkz8o6r.astroid@yuna.none>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.046 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [sync.rs, proxmox.com]
Subject: [pbs-devel] applied: [PATCH proxmox-backup] sync: switch reader
back to a shared lock
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
On April 16, 2025 10:56 am, Shannon Sterz wrote:
> the below commit accidentally switched this lock to an exclusive lock
> when it should just be a shared one as that is sufficient for a
> reader:
>
> e2c1866b: datastore/api/backup: prepare for fix of #3935 by adding
> lock helpers
>
> this has already caused failed backups for a user with a sync job that
> runs while they are trying to create a new backup.
>
> https://forum.proxmox.com/threads/165038
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>
> this also explains the issue we have seen on an internal pbs host.
>
> src/server/sync.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/server/sync.rs b/src/server/sync.rs
> index 528e2054..09814ef0 100644
> --- a/src/server/sync.rs
> +++ b/src/server/sync.rs
> @@ -480,7 +480,7 @@ impl SyncSource for LocalSource {
> ) -> Result<Arc<dyn SyncSourceReader>, Error> {
> let dir = self.store.backup_dir(ns.clone(), dir.clone())?;
> let guard = dir
> - .lock()
> + .lock_shared()
> .with_context(|| format!("while reading snapshot '{dir:?}' for a sync job"))?;
> Ok(Arc::new(LocalSourceReader {
> _dir_lock: Arc::new(Mutex::new(guard)),
> --
> 2.39.5
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel