From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id CCB331FF16F
for <inbox@lore.proxmox.com>; Tue, 15 Apr 2025 14:09:42 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 0FFCE74EF;
Tue, 15 Apr 2025 14:09:42 +0200 (CEST)
Date: Tue, 15 Apr 2025 14:09:36 +0200
From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
References: <20250415120015.886971-1-c.heiss@proxmox.com>
In-Reply-To: <20250415120015.886971-1-c.heiss@proxmox.com>
MIME-Version: 1.0
User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid)
Message-Id: <1744718847.upng3zak5d.astroid@yuna.none>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.046 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox] build.sh: allow building multiple
crates
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
On April 15, 2025 2:00 pm, Christoph Heiss wrote:
> Instead of just looking at the first argument, iterate over all of them
> and build them one by one.
>
> Useful if e.g. applying patch series or generally working with multiple
> crates in this repo, to then be able to run e.g.
>
> $ ./build.sh proxmox-log proxmox-serde
does this have any advantage over
`make proxmox-log-deb proxmox-serde-deb`
? that one even supports parallelization if desired ;)
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> build.sh | 62 +++++++++++++++++++++++++++++---------------------------
> 1 file changed, 32 insertions(+), 30 deletions(-)
>
> diff --git a/build.sh b/build.sh
> index 7aa0a85b..9857905a 100755
> --- a/build.sh
> +++ b/build.sh
> @@ -1,36 +1,38 @@
> -#!/bin/sh
> +#!/bin/bash
>
> set -e
>
> export CARGO=/usr/bin/cargo
> export RUSTC=/usr/bin/rustc
>
> -CRATE=$1
> -BUILDCMD=${BUILDCMD:-"dpkg-buildpackage -b -uc -us"}
> -BUILDDIR="${BUILDDIR:-"build"}"
> -
> -mkdir -p "${BUILDDIR}"
> -echo system >"${BUILDDIR}"/rust-toolchain
> -rm -rf ""${BUILDDIR}"/${CRATE}"
> -
> -CONTROL="$PWD/${CRATE}/debian/control"
> -
> -if [ -e "$CONTROL" ]; then
> - # check but only warn, debcargo fails anyway if crates are missing
> - dpkg-checkbuilddeps $PWD/${CRATE}/debian/control || true
> - [ "x$NOCONTROL" = 'x' ] && rm -f "$PWD/${CRATE}/debian/control"
> -fi
> -
> -debcargo package \
> - --config "$PWD/${CRATE}/debian/debcargo.toml" \
> - --changelog-ready \
> - --no-overlay-write-back \
> - --directory "$PWD/"${BUILDDIR}"/${CRATE}" \
> - "${CRATE}" \
> - "$(dpkg-parsechangelog -l "${CRATE}/debian/changelog" -SVersion | sed -e 's/-.*//')"
> -
> -cd ""${BUILDDIR}"/${CRATE}"
> -rm -f debian/source/format.debcargo.hint
> -${BUILDCMD}
> -
> -[ "x$NOCONTROL" = "x" ] && cp debian/control "$CONTROL"
> +for CRATE in "$@"; do
> + BUILDCMD=${BUILDCMD:-"dpkg-buildpackage -b -uc -us"}
> + BUILDDIR="${BUILDDIR:-"build"}"
> +
> + mkdir -p "${BUILDDIR}"
> + echo system >"${BUILDDIR}"/rust-toolchain
> + rm -rf ""${BUILDDIR}"/${CRATE}"
> +
> + CONTROL="$PWD/${CRATE}/debian/control"
> +
> + if [ -e "$CONTROL" ]; then
> + # check but only warn, debcargo fails anyway if crates are missing
> + dpkg-checkbuilddeps $PWD/${CRATE}/debian/control || true
> + [ "x$NOCONTROL" = 'x' ] && rm -f "$PWD/${CRATE}/debian/control"
> + fi
> +
> + debcargo package \
> + --config "$PWD/${CRATE}/debian/debcargo.toml" \
> + --changelog-ready \
> + --no-overlay-write-back \
> + --directory "$PWD/"${BUILDDIR}"/${CRATE}" \
> + "${CRATE}" \
> + "$(dpkg-parsechangelog -l "${CRATE}/debian/changelog" -SVersion | sed -e 's/-.*//')"
> +
> + pushd ""${BUILDDIR}"/${CRATE}"
> + rm -f debian/source/format.debcargo.hint
> + ${BUILDCMD}
> +
> + [ "x$NOCONTROL" = "x" ] && cp debian/control "$CONTROL"
> + popd
> +done
> --
> 2.48.1
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel