From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 39EB91FF16E
for <inbox@lore.proxmox.com>; Mon, 3 Mar 2025 13:58:37 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 6F845A49A;
Mon, 3 Mar 2025 13:58:33 +0100 (CET)
Date: Mon, 03 Mar 2025 13:58:26 +0100
From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
References: <20250219164847.757184-1-c.ebner@proxmox.com>
<20250219164847.757184-2-c.ebner@proxmox.com>
In-Reply-To: <20250219164847.757184-2-c.ebner@proxmox.com>
MIME-Version: 1.0
User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid)
Message-Id: <1741006240.qaf4jdvdpa.astroid@yuna.none>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.045 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox 1/2] pbs api types: add check
garbage collection atime updates flag
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
On February 19, 2025 5:48 pm, Christian Ebner wrote:
> Add the `gc-atime-check` flag to the datastore tuning parameters.
> This flag allows to enable/disable a check to detect if the atime
> update is honored by the filesystem backing the chunk store during
> phase 1 of garbage collection and during datastore creation.
>
> The default is to perform the check.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> changes since version 1:
> - Rename from check-gc-atime to gc-atime-check, so that the option is
> prefixed with gc for better association
>
> pbs-api-types/src/datastore.rs | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
> index ddd8d3c6..a7a9db7d 100644
> --- a/pbs-api-types/src/datastore.rs
> +++ b/pbs-api-types/src/datastore.rs
> @@ -229,6 +229,12 @@ pub enum DatastoreFSyncLevel {
> type: ChunkOrder,
> optional: true,
> },
> + "gc-atime-check": {
> + description: "Check filesystem atime update during store creation and garbage collection",
this should probably spell out that the check is for atime updates
*working as expected*, else this could also be interpreted to mean
"check atime during GC", which we always do ;)
maybe also encode this in the setting name?
> + optional: true,
> + default: true,
> + type: bool,
> + },
> },
> )]
> #[derive(Serialize, Deserialize, Default)]
> @@ -240,6 +246,8 @@ pub struct DatastoreTuning {
> pub chunk_order: Option<ChunkOrder>,
> #[serde(skip_serializing_if = "Option::is_none")]
> pub sync_level: Option<DatastoreFSyncLevel>,
> + #[serde(skip_serializing_if = "Option::is_none")]
> + pub gc_atime_check: Option<bool>,
> }
>
> pub const DATASTORE_TUNING_STRING_SCHEMA: Schema = StringSchema::new("Datastore tuning options")
> --
> 2.39.5
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel