From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A70B91FF173 for ; Mon, 27 Jan 2025 13:28:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 657222A164; Mon, 27 Jan 2025 13:28:12 +0100 (CET) Date: Mon, 27 Jan 2025 13:27:37 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20250127121016.247973-1-m.sandoval@proxmox.com> <20250127121016.247973-2-m.sandoval@proxmox.com> In-Reply-To: <20250127121016.247973-2-m.sandoval@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1737980603.gjlfeg0jh5.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH backup v3 2/3] remove create & truncate when create_new is used X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" this one I already applied in v2? On January 27, 2025 1:10 pm, Maximiliano Sandoval wrote: > As per its documentation [1]: > >> If .create_new(true) is set, .create() and .truncate() are ignored. > > This gets rid of the "file opened with `create`, but `truncate` > behavior not defined " clippy warnings. > > [1] https://doc.rust-lang.org/std/fs/struct.OpenOptions.html#method.create_new > > Signed-off-by: Maximiliano Sandoval > --- > pbs-datastore/src/datastore.rs | 2 +- > proxmox-backup-client/src/main.rs | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs > index fd3990d6..75c0c16a 100644 > --- a/pbs-datastore/src/datastore.rs > +++ b/pbs-datastore/src/datastore.rs > @@ -749,9 +749,9 @@ impl DataStore { > > let mut open_options = std::fs::OpenOptions::new(); > open_options.write(true); > - open_options.truncate(true); > > if force { > + open_options.truncate(true); > open_options.create(true); > } else { > open_options.create_new(true); > diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs > index 632a2917..589a097b 100644 > --- a/proxmox-backup-client/src/main.rs > +++ b/proxmox-backup-client/src/main.rs > @@ -1598,7 +1598,6 @@ async fn restore( > if let Some(target) = target { > let mut writer = std::fs::OpenOptions::new() > .write(true) > - .create(true) > .create_new(true) > .open(target) > .map_err(|err| { > @@ -1724,7 +1723,6 @@ async fn restore( > let mut writer = if let Some(target) = target { > std::fs::OpenOptions::new() > .write(true) > - .create(true) > .create_new(true) > .open(target) > .map_err(|err| format_err!("unable to create target file {:?} - {}", target, err))? > -- > 2.39.5 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel