From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 732051FF161
for <inbox@lore.proxmox.com>; Wed, 4 Dec 2024 14:50:28 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 27FA98E5F;
Wed, 4 Dec 2024 14:50:28 +0100 (CET)
Date: Wed, 04 Dec 2024 14:50:20 +0100
From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
References: <20241204083149.58754-1-c.ebner@proxmox.com>
<20241204083149.58754-2-c.ebner@proxmox.com>
In-Reply-To: <20241204083149.58754-2-c.ebner@proxmox.com>
MIME-Version: 1.0
User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid)
Message-Id: <1733320197.k5vt7i9tv1.astroid@yuna.none>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.048 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pbs-devel] applied: [PATCH v2 proxmox-backup 1/3] client: backup:
remove unnecessary clone for backup reader
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
this one already, thanks!
On December 4, 2024 9:31 am, Christian Ebner wrote:
> This was introduced by commit fdea4e53 ("client: implement prepare
> reference method") to read a reference metadata archive for detection
> of unchanged, reusable files when using change detection mode set to
> `metadata`.
>
> Avoid unnecessary cloning of the atomic reference counted
> `BackupReader` instance, as it is used exclusively for this codepath.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> changes since version 1:
> - fix incorrect commit title by s/writer/reader/
>
> proxmox-backup-client/src/main.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs
> index 9daa513f9..632a29170 100644
> --- a/proxmox-backup-client/src/main.rs
> +++ b/proxmox-backup-client/src/main.rs
> @@ -1107,7 +1107,7 @@ async fn create_backup(
> &target,
> manifest.clone(),
> &client,
> - backup_reader.clone(),
> + backup_reader,
> crypt_config.clone(),
> crypto.mode,
> )
> @@ -1310,7 +1310,7 @@ async fn prepare_reference(
> let most_used = metadata_ref_index.find_most_used_chunks(8);
> let file_info = manifest.lookup_file_info(&target)?;
> let chunk_reader = RemoteChunkReader::new(
> - backup_reader.clone(),
> + backup_reader,
> crypt_config.clone(),
> file_info.chunk_crypt_mode(),
> most_used,
> --
> 2.39.5
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel