From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DD4EC1FF161 for ; Wed, 4 Dec 2024 14:42:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6EB1C8CC2; Wed, 4 Dec 2024 14:42:45 +0100 (CET) Date: Wed, 04 Dec 2024 14:42:38 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20241203134139.399703-1-m.sandoval@proxmox.com> In-Reply-To: <20241203134139.399703-1-m.sandoval@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1733319751.rsdr3ej5wv.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied-series: [PATCH backup 1/4] datastore: docs: turn uri into hyperlink X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" thanks! On December 3, 2024 2:41 pm, Maximiliano Sandoval wrote: > Fixes the cargo doc lint: > > ``` > warning: this URL is not a hyperlink > --> pbs-datastore/src/data_blob.rs:555:5 > | > 555 | /// https://github.com/facebook/zstd/blob/dev/lib/common/error_private.h > | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > | > = note: bare URLs are not automatically turned into clickable links > = note: `#[warn(rustdoc::bare_urls)]` on by default > help: use an automatic link instead > | > 555 | /// > | + + > ``` > > Signed-off-by: Maximiliano Sandoval > --- > Found more warnings when running > > cargo doc --workspace --all > > > pbs-datastore/src/data_blob.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pbs-datastore/src/data_blob.rs b/pbs-datastore/src/data_blob.rs > index 0fb4d44c..0c05c5a4 100644 > --- a/pbs-datastore/src/data_blob.rs > +++ b/pbs-datastore/src/data_blob.rs > @@ -552,7 +552,7 @@ impl<'a, 'b> DataChunkBuilder<'a, 'b> { > /// Check if the error code returned by `zstd_safe::compress`, or anything else that does FFI calls > /// into zstd code, was `70` 'Destination buffer is too small' by subtracting the error code from > /// `0` (with underflow), see `ERR_getErrorCode` in > -/// https://github.com/facebook/zstd/blob/dev/lib/common/error_private.h > +/// > /// > /// There is a test below to ensure we catch any change in the interface or internal value. > fn zstd_error_is_target_too_small(err: usize) -> bool { > -- > 2.39.5 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel