From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 0DE8F1FF170
for <inbox@lore.proxmox.com>; Tue, 3 Dec 2024 11:26:38 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 7A9A36CE;
Tue, 3 Dec 2024 11:26:43 +0100 (CET)
Date: Tue, 03 Dec 2024 11:26:37 +0100
From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
References: <20241202131008.410529-1-m.sandoval@proxmox.com>
In-Reply-To: <20241202131008.410529-1-m.sandoval@proxmox.com>
MIME-Version: 1.0
User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid)
Message-Id: <1733221580.sw0m2xgrqz.astroid@yuna.none>
X-SPAM-LEVEL: Spam detection results: 1
AWL -0.002 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
FSL_BULK_SIG 0.001 Bulk signature with no Unsubscribe
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RAZOR2_CF_RANGE_51_100 1.886 Razor2 gives confidence level above 50%
RAZOR2_CHECK 0.922 Listed in Razor2 (http://razor.sf.net/)
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [mod.rs, chunker.rs, proxmox.com, wikipedia.org,
rust-lang.github.io]
URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist
[185.199.109.153, 185.199.110.153, 185.199.108.153, 185.199.111.153]
Subject: [pbs-devel] applied-series: [PATCH backup 1/3] docs: remove empty
lines in doc strings
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
thanks!
On December 2, 2024 2:10 pm, Maximiliano Sandoval wrote:
> Fixes the clippy lint:
>
> ```
> warning: empty line after doc comment
> --> src/tape/pool_writer/mod.rs:441:5
> |
> 441 | / /// updated.
> 442 | |
> | |_
> ...
> 448 | / pub fn append_snapshot_archive(
> 449 | | &mut self,
> 450 | | snapshot_reader: &SnapshotReader,
> 451 | | ) -> Result<(bool, usize), Error> {
> | |_____________________________________- the comment documents this method
> |
> = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
> = help: if the empty line is unintentional remove it
> help: if the documentation should include the empty line include it in the comment
> |
> 442 | ///
> |
> ```
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> pbs-client/src/catalog_shell.rs | 1 -
> pbs-datastore/src/chunker.rs | 1 -
> src/tape/pool_writer/mod.rs | 4 ++--
> 3 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/pbs-client/src/catalog_shell.rs b/pbs-client/src/catalog_shell.rs
> index 550daf56b..20f323a22 100644
> --- a/pbs-client/src/catalog_shell.rs
> +++ b/pbs-client/src/catalog_shell.rs
> @@ -303,7 +303,6 @@ async fn restore_command(target: String, pattern: Option<String>) -> Result<(),
> /// The `Path` type's component iterator does not tell us anything about trailing slashes or
> /// trailing `Component::CurDir` entries. Since we only support regular paths we'll roll our own
> /// here:
> -
> pub struct Shell {
> /// Readline instance handling input and callbacks
> rl: rustyline::Editor<CliHelper>,
> diff --git a/pbs-datastore/src/chunker.rs b/pbs-datastore/src/chunker.rs
> index ecdbca296..bf1e8d8df 100644
> --- a/pbs-datastore/src/chunker.rs
> +++ b/pbs-datastore/src/chunker.rs
> @@ -30,7 +30,6 @@ pub trait Chunker {
> /// information please take a look at the [Rolling
> /// Hash](https://en.wikipedia.org/wiki/Rolling_hash) article from
> /// Wikipedia.
> -
> pub struct ChunkerImpl {
> h: u32,
> window_size: usize,
> diff --git a/src/tape/pool_writer/mod.rs b/src/tape/pool_writer/mod.rs
> index 9731e1cc8..3114ec061 100644
> --- a/src/tape/pool_writer/mod.rs
> +++ b/src/tape/pool_writer/mod.rs
> @@ -332,7 +332,7 @@ impl PoolWriter {
>
> /// Move to EOM (if not already there), then write the current
> /// catalog to the tape. On success, this return 'Ok(true)'.
> -
> + ///
> /// Please note that this may fail when there is not enough space
> /// on the media (return value 'Ok(false, _)'). In that case, the
> /// archive is marked incomplete. The caller should mark the media
> @@ -439,7 +439,7 @@ impl PoolWriter {
> /// archive writing specified files (as .pxar) into it. On
> /// success, this return 'Ok(true)' and the media catalog gets
> /// updated.
> -
> + ///
> /// Please note that this may fail when there is not enough space
> /// on the media (return value 'Ok(false, _)'). In that case, the
> /// archive is marked incomplete, and we do not use it. The caller
> --
> 2.39.5
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel