From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A17571FF15F for <inbox@lore.proxmox.com>; Mon, 2 Dec 2024 15:01:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AFA3D19971; Mon, 2 Dec 2024 15:02:04 +0100 (CET) Date: Mon, 02 Dec 2024 15:01:57 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com> To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> References: <20241129142801.3334969-1-d.csapak@proxmox.com> <20241129142801.3334969-2-d.csapak@proxmox.com> In-Reply-To: <20241129142801.3334969-2-d.csapak@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1733148059.vmue2ssrq8.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox v2 2/2] sys: open directories with O_CLOEXEC X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> b25lIHNtYWxsIG5pdCBpbmxpbmUsIG90aGVyd2lzZToKClJldmlld2VkLWJ5OiBGYWJpYW4gR3LD vG5iaWNobGVyIDxmLmdydWVuYmljaGxlckBwcm94bW94LmNvbT4KCk9uIE5vdmVtYmVyIDI5LCAy MDI0IDM6MjggcG0sIERvbWluaWsgQ3NhcGFrIHdyb3RlOgo+IHNvIHRoZXkgZG9uJ3QgbGluZ2Vy IGFyb3VuZCBpbiBjYXNlIG9mIGEgZGFlbW9uIHJlbG9hZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBE b21pbmlrIENzYXBhayA8ZC5jc2FwYWtAcHJveG1veC5jb20+Cj4gLS0tCj4gbmV3IGluIHYyCj4g IHByb3htb3gtc3lzL3NyYy9mZC5ycyAgICAgfCAgMiArLQo+ICBwcm94bW94LXN5cy9zcmMvZnMv ZGlyLnJzIHwgMTUgKysrKysrKysrLS0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0 aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvcHJveG1veC1zeXMvc3Jj L2ZkLnJzIGIvcHJveG1veC1zeXMvc3JjL2ZkLnJzCj4gaW5kZXggOGQ4NWJkMmUuLjM4NmU0MjIy IDEwMDY0NAo+IC0tLSBhL3Byb3htb3gtc3lzL3NyYy9mZC5ycwo+ICsrKyBiL3Byb3htb3gtc3lz L3NyYy9mZC5ycwo+IEBAIC0yNCw3ICsyNCw3IEBAIHB1YiBmbiBjaGFuZ2VfY2xvZXhlYyhmZDog UmF3RmQsIG9uOiBib29sKSAtPiBSZXN1bHQ8KCksIGFueWhvdzo6RXJyb3I+IHsKPiAgfQo+ICAK PiAgcHViKGNyYXRlKSBmbiBjd2QoKSAtPiBSZXN1bHQ8T3duZWRGZCwgbml4OjpFcnJvcj4gewo+ IC0gICAgb3BlbigiLiIsIE9GbGFnOjpPX0RJUkVDVE9SWSwgc3RhdDo6TW9kZTo6ZW1wdHkoKSkK PiArICAgIG9wZW4oIi4iLCBjcmF0ZTo6ZnM6OkRJUl9GTEFHUywgc3RhdDo6TW9kZTo6ZW1wdHko KSkKPiAgfQo+ICAKPiAgcHViIGZuIG9wZW48UD4ocGF0aDogJlAsIG9mbGFnOiBPRmxhZywgbW9k ZTogTW9kZSkgLT4gUmVzdWx0PE93bmVkRmQsIG5peDo6RXJyb3I+Cj4gZGlmZiAtLWdpdCBhL3By b3htb3gtc3lzL3NyYy9mcy9kaXIucnMgYi9wcm94bW94LXN5cy9zcmMvZnMvZGlyLnJzCj4gaW5k ZXggYzkwM2FiODcuLmEwOTNlZDk5IDEwMDY0NAo+IC0tLSBhL3Byb3htb3gtc3lzL3NyYy9mcy9k aXIucnMKPiArKysgYi9wcm94bW94LXN5cy9zcmMvZnMvZGlyLnJzCj4gQEAgLTE0LDYgKzE0LDkg QEAgdXNlIHByb3htb3hfbGFuZzo6dHJ5X2Jsb2NrOwo+ICAKPiAgdXNlIGNyYXRlOjpmczo6e2Zj aG93biwgQ3JlYXRlT3B0aW9uc307Cj4gIAo+ICsvLy8gVGhlIGRlZmF1bHQgW2BPRmxhZ2BdIHdl IHdhbnQgdG8gdXNlIHdoZW4gb3BlbmluZyBkaXJlY3Rvcmllcy4KPiArcHViKGNyYXRlKSBjb25z dCBESVJfRkxBR1M6IE9GbGFnID0gT0ZsYWc6Ok9fRElSRUNUT1JZLnVuaW9uKE9GbGFnOjpPX0NM T0VYRUMpOwoKbml0OiBJIHRoaW5rIEknZCBwcmVmZXIgYSBwbGFpbiBgfGAgaGVyZSAodGhleSBh cmUgdGhlIHNhbWUgaW4gdGhlCmJpdGZsYWdzIGNyYXRlLCB3aGljaCB0aGlzIGlzIHVuZGVyIHRo ZSBob29kKS4KCj4gKwo+ICAvLy8gQ3JlYXRlcyBkaXJlY3RvcnkgYXQgdGhlIHByb3ZpZGVkIHBh dGggd2l0aCBzcGVjaWZpZWQgb3duZXJzaGlwLgo+ICAvLy8KPiAgLy8vIEVycm9ycyBpZiB0aGUg ZGlyZWN0b3J5IGFscmVhZHkgZXhpc3RzLgo+IEBAIC02Niw3ICs2OSw3IEBAIHB1YiBmbiBlbnN1 cmVfZGlyX2V4aXN0czxQOiBBc1JlZjxQYXRoPj4oCj4gICAgICAgICAgRXJyKGVycikgPT4gYmFp bCEoInVuYWJsZSB0byBjcmVhdGUgZGlyZWN0b3J5IHtwYXRoOj99IC0ge2Vycn0iLCksCj4gICAg ICB9Cj4gIAo+IC0gICAgbGV0IGZkID0gbml4OjpmY250bDo6b3BlbihwYXRoLCBPRmxhZzo6T19E SVJFQ1RPUlksIHN0YXQ6Ok1vZGU6OmVtcHR5KCkpCj4gKyAgICBsZXQgZmQgPSBuaXg6OmZjbnRs OjpvcGVuKHBhdGgsIERJUl9GTEFHUywgc3RhdDo6TW9kZTo6ZW1wdHkoKSkKPiAgICAgICAgICAu bWFwKHxmZHwgdW5zYWZlIHsgT3duZWRGZDo6ZnJvbV9yYXdfZmQoZmQpIH0pCj4gICAgICAgICAg Lm1hcF9lcnIofGVycnwgZm9ybWF0X2VyciEoInVuYWJsZSB0byBvcGVuIGNyZWF0ZWQgZGlyZWN0 b3J5IHtwYXRoOj99IC0ge2Vycn0iKSk/Owo+ICAgICAgLy8gdW1hc2sgZGVmYXVsdHMgdG8gMDIy IHNvIG1ha2Ugc3VyZSB0aGUgbW9kZSBpcyBmdWxseSBob25vd2VkOgo+IEBAIC0xMjAsNyArMTIz LDcgQEAgZm4gY3JlYXRlX3BhdGhfZG8oCj4gICAgICAgICAgU29tZShDb21wb25lbnQ6OlByZWZp eChfKSkgPT4gYmFpbCEoImlsbGVnYWwgcHJlZml4IHBhdGggY29tcG9uZW50IGVuY291bnRlcmVk IiksCj4gICAgICAgICAgU29tZShDb21wb25lbnQ6OlJvb3REaXIpID0+IHsKPiAgICAgICAgICAg ICAgbGV0IF8gPSBpdGVyLm5leHQoKTsKPiAtICAgICAgICAgICAgY3JhdGU6OmZkOjpvcGVuKGMi LyIsIE9GbGFnOjpPX0RJUkVDVE9SWSwgc3RhdDo6TW9kZTo6ZW1wdHkoKSk/Cj4gKyAgICAgICAg ICAgIGNyYXRlOjpmZDo6b3BlbihjIi8iLCBESVJfRkxBR1MsIHN0YXQ6Ok1vZGU6OmVtcHR5KCkp Pwo+ICAgICAgICAgIH0KPiAgICAgICAgICBTb21lKENvbXBvbmVudDo6Q3VyRGlyKSA9PiB7Cj4g ICAgICAgICAgICAgIGxldCBfID0gaXRlci5uZXh0KCk7Cj4gQEAgLTEyOCw3ICsxMzEsNyBAQCBm biBjcmVhdGVfcGF0aF9kbygKPiAgICAgICAgICB9Cj4gICAgICAgICAgU29tZShDb21wb25lbnQ6 OlBhcmVudERpcikgPT4gewo+ICAgICAgICAgICAgICBsZXQgXyA9IGl0ZXIubmV4dCgpOwo+IC0g ICAgICAgICAgICBjcmF0ZTo6ZmQ6Om9wZW4oYyIuLiIsIE9GbGFnOjpPX0RJUkVDVE9SWSwgc3Rh dDo6TW9kZTo6ZW1wdHkoKSk/Cj4gKyAgICAgICAgICAgIGNyYXRlOjpmZDo6b3BlbihjIi4uIiwg RElSX0ZMQUdTLCBzdGF0OjpNb2RlOjplbXB0eSgpKT8KPiAgICAgICAgICB9Cj4gICAgICAgICAg U29tZShDb21wb25lbnQ6Ok5vcm1hbChfKSkgPT4gewo+ICAgICAgICAgICAgICAvLyBzaW1wbHkg ZG8gbm90IGFkdmFuY2UgdGhlIGl0ZXJhdG9yLCBoZWF2eSBsaWZ0aW5nIGhhcHBlbnMgaW4gY3Jl YXRlX3BhdGhfYXRfZG8oKQo+IEBAIC0xNTQsNyArMTU3LDcgQEAgZm4gY3JlYXRlX3BhdGhfYXRf ZG8oCj4gICAgICAgICAgICAgIE5vbmUgPT4gcmV0dXJuIE9rKGNyZWF0ZWQpLAo+ICAKPiAgICAg ICAgICAgICAgU29tZShDb21wb25lbnQ6OlBhcmVudERpcikgPT4gewo+IC0gICAgICAgICAgICAg ICAgYXQgPSBjcmF0ZTo6ZmQ6Om9wZW5hdCgmYXQsIGMiLi4iLCBPRmxhZzo6T19ESVJFQ1RPUlks IHN0YXQ6Ok1vZGU6OmVtcHR5KCkpPzsKPiArICAgICAgICAgICAgICAgIGF0ID0gY3JhdGU6OmZk OjpvcGVuYXQoJmF0LCBjIi4uIiwgRElSX0ZMQUdTLCBzdGF0OjpNb2RlOjplbXB0eSgpKT87Cj4g ICAgICAgICAgICAgIH0KPiAgCj4gICAgICAgICAgICAgIFNvbWUoQ29tcG9uZW50OjpOb3JtYWwo cGF0aCkpID0+IHsKPiBAQCAtMTc1LDcgKzE3OCw3IEBAIGZuIGNyZWF0ZV9wYXRoX2F0X2RvKAo+ ICAgICAgICAgICAgICAgICAgICAgIEVycihlKSA9PiByZXR1cm4gRXJyKGUuaW50bygpKSwKPiAg ICAgICAgICAgICAgICAgICAgICBPayhfKSA9PiB0cnVlLAo+ICAgICAgICAgICAgICAgICAgfTsK PiAtICAgICAgICAgICAgICAgIGF0ID0gY3JhdGU6OmZkOjpvcGVuYXQoJmF0LCBwYXRoLCBPRmxh Zzo6T19ESVJFQ1RPUlksIHN0YXQ6Ok1vZGU6OmVtcHR5KCkpPzsKPiArICAgICAgICAgICAgICAg IGF0ID0gY3JhdGU6OmZkOjpvcGVuYXQoJmF0LCBwYXRoLCBESVJfRkxBR1MsIHN0YXQ6Ok1vZGU6 OmVtcHR5KCkpPzsKPiAgCj4gICAgICAgICAgICAgICAgICBpZiBsZXQgKHRydWUsIFNvbWUob3B0 cykpID0gKGNyZWF0ZWQsIG9wdHMpIHsKPiAgICAgICAgICAgICAgICAgICAgICBpZiBvcHRzLm93 bmVyLmlzX3NvbWUoKSB8fCBvcHRzLmdyb3VwLmlzX3NvbWUoKSB7Cj4gQEAgLTIyMiw3ICsyMjUs NyBAQCBwdWIgZm4gbWFrZV90bXBfZGlyPFA6IEFzUmVmPFBhdGg+PigKPiAgCj4gICAgICBpZiBs ZXQgU29tZShvcHRpb25zKSA9IG9wdGlvbnMgewo+ICAgICAgICAgIGlmIGxldCBFcnIoZXJyKSA9 IHRyeV9ibG9jayEoewo+IC0gICAgICAgICAgICBsZXQgbXV0IGZkID0gY3JhdGU6OmZkOjpvcGVu KCZwYXRoLCBPRmxhZzo6T19ESVJFQ1RPUlksIHN0YXQ6Ok1vZGU6OmVtcHR5KCkpPzsKPiArICAg ICAgICAgICAgbGV0IG11dCBmZCA9IGNyYXRlOjpmZDo6b3BlbigmcGF0aCwgRElSX0ZMQUdTLCBz dGF0OjpNb2RlOjplbXB0eSgpKT87Cj4gICAgICAgICAgICAgIG9wdGlvbnMuYXBwbHlfdG8oJm11 dCBmZCwgJnBhdGgpPzsKPiAgICAgICAgICAgICAgT2s6OjwoKSwgRXJyb3I+KCgpKQo+ICAgICAg ICAgIH0pIHsKPiAtLSAKPiAyLjM5LjUKPiAKPiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+IHBicy1kZXZlbCBtYWlsaW5nIGxpc3QKPiBwYnMt ZGV2ZWxAbGlzdHMucHJveG1veC5jb20KPiBodHRwczovL2xpc3RzLnByb3htb3guY29tL2NnaS1i aW4vbWFpbG1hbi9saXN0aW5mby9wYnMtZGV2ZWwKPiAKPiAKPiAKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpwYnMtZGV2ZWwgbWFpbGluZyBsaXN0CnBi cy1kZXZlbEBsaXN0cy5wcm94bW94LmNvbQpodHRwczovL2xpc3RzLnByb3htb3guY29tL2NnaS1i aW4vbWFpbG1hbi9saXN0aW5mby9wYnMtZGV2ZWwK