From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3876B1FF168 for ; Tue, 26 Nov 2024 13:42:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C81B83A2; Tue, 26 Nov 2024 13:42:10 +0100 (CET) Date: Tue, 26 Nov 2024 13:41:35 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Christian Ebner , Proxmox Backup Server development discussion References: <20241126122419.235890-1-c.ebner@proxmox.com> <1d5d8a7b-f31c-4f1a-bc69-814e57455e3d@proxmox.com> In-Reply-To: <1d5d8a7b-f31c-4f1a-bc69-814e57455e3d@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1732624756.2bm5wbhpr8.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] api types: add missing conf to blob archive name mapping X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On November 26, 2024 1:35 pm, Thomas Lamprecht wrote: > Am 26.11.24 um 13:24 schrieb Christian Ebner: >> Commit addfae26 ("api types: introduce `BackupArchiveName` type") >> introduced a dedicated archive name api type to add rust type >> checking and bundle helpers to the api type. Since this, the backup >> archive name to server archive name mapping is handled by its parser. > > This is mostly relevant for the client or? I.e., this has no impact on > community implementations/experiments adding completely different archive > types? yes, this is just a UX shortcut that allows leaving out the .blob extension for blob types used by our stack. if you use a custom blob type, you need to specify the full name including .blob when passing the name to the client. the reason is that with a generic catch-all matching to blob, we'd take away our ability to add new index types without breaking clients relying on that magic. i.e., if a client could do `restore ... my_custom_blob.foobar`, we can't add a `foobar` index/archive type ourselves later on without breaking that client. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel