From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E3B1D1FF168 for ; Tue, 26 Nov 2024 13:32:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D78452FF86; Tue, 26 Nov 2024 13:32:41 +0100 (CET) Date: Tue, 26 Nov 2024 13:32:06 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20241126122419.235890-1-c.ebner@proxmox.com> In-Reply-To: <20241126122419.235890-1-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1732624320.03tnpelt4j.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs, proxmox.com] Subject: [pbs-devel] applied: [PATCH proxmox-backup] api types: add missing conf to blob archive name mapping X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On November 26, 2024 1:24 pm, Christian Ebner wrote: > Commit addfae26 ("api types: introduce `BackupArchiveName` type") > introduced a dedicated archive name api type to add rust type > checking and bundle helpers to the api type. Since this, the backup > archive name to server archive name mapping is handled by its parser. > > This however did not cover the `.conf` extension used for VM config > files. Add the missing `.conf` to `.conf.blob` to the match statement > and the test cases. > > Fixes: addfae26 ("api types: introduce `BackupArchiveName` type") > Reported-by: Stoiko Ivanov > Signed-off-by: Christian Ebner > --- > pbs-api-types/src/datastore.rs | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs > index 4927f3724..688b7dd03 100644 > --- a/pbs-api-types/src/datastore.rs > +++ b/pbs-api-types/src/datastore.rs > @@ -1833,6 +1833,7 @@ impl BackupArchiveName { > Some("ppxar") => ArchiveType::DynamicIndex, > Some("pcat1") => ArchiveType::DynamicIndex, > Some("img") => ArchiveType::FixedIndex, > + Some("conf") => ArchiveType::Blob, > Some("json") => ArchiveType::Blob, > Some("key") => ArchiveType::Blob, > Some("log") => ArchiveType::Blob, > @@ -1910,6 +1911,8 @@ mod tests { > "/valid/rsa-encrypted.key.blob", > "/valid/archive-name.log", > "/valid/archive-name.log.blob", > + "/valid/qemu-server.conf", > + "/valid/qemu-server.conf.blob", > ]; > > for archive_name in valid_archive_names { > -- > 2.39.5 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel