From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0DEA91FF168 for ; Tue, 26 Nov 2024 13:27:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 79E642FDC3; Tue, 26 Nov 2024 13:27:24 +0100 (CET) Date: Tue, 26 Nov 2024 13:26:47 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20241126120357.389046-1-s.ivanov@proxmox.com> In-Reply-To: <20241126120357.389046-1-s.ivanov@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1732623296.vf1tluw47l.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup-restore-image] kernel: enable codepage 437 for vfat support X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" adding missing subject prefix ;) On November 26, 2024 1:03 pm, Stoiko Ivanov wrote: > ran into an issue when clicking on the ESP of a VM while trying > single-file restore. > > the added config-config options are taken from config-6.5.13-6-pve > (the restore-image is still based on kernel 6.5) - and I tried copying > a small set around the needed options. maybe we should upgrade to a newer one at some point (might also benefit from NTFS bug fixes and added features..) > > with the patch the ESP contents are shown successfully > > Signed-off-by: Stoiko Ivanov > --- > src/config-base | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/config-base b/src/config-base > index 1581b09..238d93c 100644 > --- a/src/config-base > +++ b/src/config-base > @@ -144,6 +144,11 @@ CONFIG_ISO9660_FS=y > CONFIG_NTFS3_FS=y > CONFIG_MSDOS_FS=y > CONFIG_VFAT_FS=y > +CONFIG_FAT_DEFAULT_CODEPAGE=437 > +CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1" these two are the default values anyway and already set without this patch? > +CONFIG_NLS=y this one is set as well > +CONFIG_NLS_DEFAULT="utf8" the upstream default for this is iso8859-1, but it also says this is "the NLS used by your console, not the NLS used by a specific file system (if different) to store data (filenames) on disk." - whatever that means exactly? > +CONFIG_NLS_CODEPAGE_437=y shouldn't we also enable NLS_UTF8 ? I mean, I guess it doesn't really matter as long as we don't start setting the corresponding mount options to force a specific codepage? the last option seems to be the only one that is actually missing from our config ;) althoug hit doesn't hurt to set any of the above explicitly I guess.. > > # memory hotplug > CONFIG_MEMORY_HOTPLUG=y > -- > 2.39.5 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel