From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 44E041FF168 for <inbox@lore.proxmox.com>; Tue, 26 Nov 2024 10:21:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B08922B01B; Tue, 26 Nov 2024 10:21:40 +0100 (CET) Date: Tue, 26 Nov 2024 10:21:34 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com> To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> References: <20241125174012.678523-1-c.ebner@proxmox.com> In-Reply-To: <20241125174012.678523-1-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1732612836.peebn527cp.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/4] use same config section type for all sync jobs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> FWIW, did a quick do-over and testing and found no issues with these two series combined. On November 25, 2024 6:40 pm, Christian Ebner wrote: > This patch series drops the `sync-push` config section type in favor of > using the same `sync` for both, sync jobs in push and pull direction. > Instead, encode the sync direction as optional parameter in the sync job > config, defaulting to sync in pull direction. This reduces complexity by > allowing to drop the optional parameter for most function calls. > For api methods, the default remains to only show sync directions in > pull direction, if no ListSyncDirection::All is passed, or the direction > explicitly selected. This allows to default to show both directions in > future Proxmox Backup Server version. > > This patch series depends on Dominik's patch series found here: > https://lore.proxmox.com/pbs-devel/377618fd-0ea9-46ba-9aec-a47387eca50d@proxmox.com/T > > Christian Ebner (4): > config: sync: use same config section type `sync` for push and pull > api: admin/config: introduce sync direction as job config parameter > bin: show direction in sync job list output > api types: drop unused config type helpers for sync direction > > pbs-api-types/src/jobs.rs | 25 ++-- > pbs-config/src/sync.rs | 17 +-- > src/api2/admin/sync.rs | 18 +-- > src/api2/config/datastore.rs | 16 +-- > src/api2/config/notifications/mod.rs | 19 ++-- > src/api2/config/sync.rs | 151 ++++++++----------------- > src/bin/proxmox-backup-proxy.rs | 22 +--- > src/bin/proxmox_backup_manager/sync.rs | 6 +- > src/server/sync.rs | 2 +- > 9 files changed, 88 insertions(+), 188 deletions(-) > > -- > 2.39.5 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel