From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 810F11FF164 for ; Fri, 22 Nov 2024 10:04:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2A1A3DB5C; Fri, 22 Nov 2024 10:05:06 +0100 (CET) MIME-Version: 1.0 In-Reply-To: <20241121154337.471425-1-c.ebner@proxmox.com> References: <20241121154337.471425-1-c.ebner@proxmox.com> From: Fabian =?utf-8?q?Gr=C3=BCnbichler?= To: Christian Ebner , pbs-devel@lists.proxmox.com Date: Fri, 22 Nov 2024 10:04:55 +0100 Message-ID: <173226629516.2118190.12004996331483257411@yuna.proxmox.com> User-Agent: alot/0.10 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] partially-applied: [PATCH proxmox-backup 0/4] improve push sync job log messages X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" applied patchs 1, 2 and 4 with some small follow-ups: - moved the remove snapshot/group success logging into the corresponding code path, so that failures don't log twice/wrong information - replaced the abort for non-owned groups in the last patch with a skip, we haven't started uploading yet at that point, so we can't abort anything. comments for patch 3 in a separate mail. Quoting Christian Ebner (2024-11-21 16:43:33) > This is a small series of patches with the intend to improve the log > messages for the sync job in push direction, mainly adding context to > error messages from the remote when the error stems from an api call, > limiting line length and improving usage of consistent terms for better > readablility and easier understanding. > > Christian Ebner (4): > server: push: fix needless borrow clippy warning > server: push: consistently use remote over target for error messages > server: push: add error context to all target api calls > server: push: various smaller improvements to error messages > > src/server/push.rs | 79 ++++++++++++++++++++++++++++------------------ > 1 file changed, 49 insertions(+), 30 deletions(-) > > -- > 2.39.5 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel