From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 980AA1FF164
for <inbox@lore.proxmox.com>; Fri, 22 Nov 2024 09:02:23 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 66E7ABF23;
Fri, 22 Nov 2024 09:02:31 +0100 (CET)
MIME-Version: 1.0
In-Reply-To: <20241113124047.97456-1-h.laimer@proxmox.com>
References: <20241113124047.97456-1-h.laimer@proxmox.com>
From: Fabian =?utf-8?q?Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>, pbs-devel@lists.proxmox.com
Date: Fri, 22 Nov 2024 09:01:53 +0100
Message-ID: <173226251335.2118190.721601310758920434@yuna.proxmox.com>
User-Agent: alot/0.10
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.049 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup] chunk_store: fix
problem with permission checking
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
with Gabriel's trailers folded in. we can always make this more relaxed if
issues pop up.
Quoting Hannes Laimer (2024-11-13 13:40:47)
> Permissions are stored in the lower 9 bits (rwxrwxrwx),
> so we have to mask `st_mode` with 0o777.
> The datastore root dir is created with 755, the `.chunks` dir and its
> contents with 750 and the `.lock` file with 644, this changes the
> expected permissions accordingly.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> pbs-datastore/src/chunk_store.rs | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/pbs-datastore/src/chunk_store.rs b/pbs-datastore/src/chunk_store.rs
> index 38a88584..29d5874a 100644
> --- a/pbs-datastore/src/chunk_store.rs
> +++ b/pbs-datastore/src/chunk_store.rs
> @@ -576,7 +576,7 @@ impl ChunkStore {
> Ok(stat) => {
> if stat.st_uid != u32::from(pbs_config::backup_user()?.uid)
> || stat.st_gid != u32::from(pbs_config::backup_group()?.gid)
> - || stat.st_mode != file_mode
> + || stat.st_mode & 0o777 != file_mode
> {
> bail!(
> "unable to open existing chunk store path {:?} - permissions or owner not correct",
> @@ -598,22 +598,22 @@ impl ChunkStore {
> /// subdirectories and the lock file.
> pub fn verify_chunkstore<T: AsRef<Path>>(path: T) -> Result<(), Error> {
> // Check datastore root path perm/owner
> - ChunkStore::check_permissions(path.as_ref(), 0o700)?;
> + ChunkStore::check_permissions(path.as_ref(), 0o755)?;
>
> let chunk_dir = Self::chunk_dir(path.as_ref());
> // Check datastore .chunks path perm/owner
> - ChunkStore::check_permissions(&chunk_dir, 0o700)?;
> + ChunkStore::check_permissions(&chunk_dir, 0o750)?;
>
> // Check all .chunks subdirectories
> for i in 0..64 * 1024 {
> let mut l1path = chunk_dir.clone();
> l1path.push(format!("{:04x}", i));
> - ChunkStore::check_permissions(&l1path, 0o700)?;
> + ChunkStore::check_permissions(&l1path, 0o750)?;
> }
>
> // Check .lock file
> let lockfile_path = Self::lockfile_path(path.as_ref());
> - ChunkStore::check_permissions(lockfile_path, 0o600)?;
> + ChunkStore::check_permissions(lockfile_path, 0o644)?;
> Ok(())
> }
> }
> --
> 2.39.5
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel