From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D03241FF163 for ; Thu, 21 Nov 2024 13:25:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B18581D3C5; Thu, 21 Nov 2024 13:25:51 +0100 (CET) Date: Thu, 21 Nov 2024 13:25:15 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20241114144114.375987-1-c.ebner@proxmox.com> In-Reply-To: <20241114144114.375987-1-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1732191900.4xn1zu55fm.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied-series: [PATCH v2 proxmox-backup 0/5] fix #5853: ignore stale files X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" thanks! this version looks much cleaner now :) On November 14, 2024 3:41 pm, Christian Ebner wrote: > When files and their associated metadata get invalidated, I/O > operations on network filesystems return ESTALE to indicate that the > filehandle does not reference a valid file anymore. > > Currently, the proxmox-backup-client does not cover such cases, it > will fail with a hard error when a stale file handle is encountered. > Any concurrent operation invalidating file handles has the potential > to lead to the backups failing if timed accordingly. For local > filesystems this is not an issue, as the file remains accessible > until the file handle is closed. > > Make the backup client more resilient by handling the ESTALE errors > gracefully, warning the user about the vanished/invalidated files, > while generating a valid and consistent backup archive nevertheless. > > Changes since version 1: > - Avoid tuples in return values by downcasting anyhow::Error to Errno > when latter is required > - Add report stale file handle helper > - Refactor report vanished/changed file helpers > > Christian Ebner (5): > client: pxar: refactor report vanished/changed helpers > client: pxar: skip directories on stale file handle > client: pxar: skip directory entries on stale file handle > client: pxar: warn user and ignore stale file handles on file open > fix #5853: client: pxar: exclude stale files on metadata/link read > > pbs-client/src/pxar/create.rs | 94 +++++++++++++++++++++++++---------- > 1 file changed, 69 insertions(+), 25 deletions(-) > > -- > 2.39.5 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel