From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1E6491FF161 for ; Wed, 20 Nov 2024 14:12:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E36DDF3C4; Wed, 20 Nov 2024 14:12:25 +0100 (CET) MIME-Version: 1.0 In-Reply-To: <20241105104015.162094-3-g.goller@proxmox.com> References: <20241105104015.162094-1-g.goller@proxmox.com> <20241105104015.162094-3-g.goller@proxmox.com> From: Fabian =?utf-8?q?Gr=C3=BCnbichler?= To: Gabriel Goller , pbs-devel@lists.proxmox.com Date: Wed, 20 Nov 2024 14:12:17 +0100 Message-ID: <173210833764.198988.6832521006255309425@yuna.proxmox.com> User-Agent: alot/0.10 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-backup-manager.rs, proxmox.com] Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 2/3] fix #3786: ui/cli: add resync-corrupt option on sync-jobs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" nit: might look better moved to the right side of the window, but no hard feelings either way Quoting Gabriel Goller (2024-11-05 11:40:14) > Add the `resync-corrupt` option to the ui and the > `proxmox-backup-manager` cli. It is listed in the `Advanced` section, > because it slows the sync-job down and is useless if no verification > job was run beforehand. > > Originally-by: Shannon Sterz > Signed-off-by: Gabriel Goller > --- > src/bin/proxmox-backup-manager.rs | 9 +++++++++ > www/window/SyncJobEdit.js | 11 +++++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/src/bin/proxmox-backup-manager.rs b/src/bin/proxmox-backup-manager.rs > index 38a1cf0f5881..08728e9d7250 100644 > --- a/src/bin/proxmox-backup-manager.rs > +++ b/src/bin/proxmox-backup-manager.rs > @@ -339,6 +339,10 @@ fn task_mgmt_cli() -> CommandLineInterface { > schema: TRANSFER_LAST_SCHEMA, > optional: true, > }, > + "resync-corrupt": { > + schema: RESYNC_CORRUPT_SCHEMA, > + optional: true, > + }, > } > } > )] > @@ -355,6 +359,7 @@ async fn pull_datastore( > group_filter: Option>, > limit: RateLimitConfig, > transfer_last: Option, > + resync_corrupt: Option, > param: Value, > ) -> Result { > let output_format = get_output_format(¶m); > @@ -391,6 +396,10 @@ async fn pull_datastore( > args["transfer-last"] = json!(transfer_last) > } > > + if let Some(resync_corrupt) = resync_corrupt { > + args["resync-corrupt"] = Value::from(resync_corrupt); > + } > + > let mut limit_json = json!(limit); > let limit_map = limit_json > .as_object_mut() > diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js > index 6543995e8800..a3c497fc2185 100644 > --- a/www/window/SyncJobEdit.js > +++ b/www/window/SyncJobEdit.js > @@ -321,6 +321,17 @@ Ext.define('PBS.window.SyncJobEdit', { > deleteEmpty: '{!isCreate}', > }, > }, > + { > + fieldLabel: gettext('Resync corrupt snapshots'), > + xtype: 'proxmoxcheckbox', > + name: 'resync-corrupt', > + autoEl: { > + tag: 'div', > + 'data-qtip': gettext('Re-sync snapshots, whose verfification failed.'), > + }, > + uncheckedValue: false, > + value: false, > + }, > ], > }, > { > -- > 2.39.5 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel