Re: [pbs-devel] [PATCH v6 proxmox-backup 08/29] api types: define remote permissions and roles for push sync

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

Quoting Christian Ebner (2024-10-31 13:14:58)
> Adding the privileges to allow backup, namespace creation and prune
> on remote targets, to be used for sync jobs in push direction.
> 
> Also adds dedicated roles setting the required privileges.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> changes since version 5:
> - dedicated remote datastore modify and remote datastore prune roles
> - remove local datastore read access for sync job push operator
> 
>  pbs-api-types/src/acl.rs | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/pbs-api-types/src/acl.rs b/pbs-api-types/src/acl.rs
> index a8ae57a9d..68ed59105 100644
> --- a/pbs-api-types/src/acl.rs
> +++ b/pbs-api-types/src/acl.rs
> @@ -58,6 +58,12 @@ constnamedbitmap! {
>          PRIV_REMOTE_MODIFY("Remote.Modify");
>          /// Remote.Read allows reading data from a configured `Remote`
>          PRIV_REMOTE_READ("Remote.Read");
> +        /// Remote.DatastoreBackup allows creating new snapshots on remote datastores
> +        PRIV_REMOTE_DATASTORE_BACKUP("Remote.DatastoreBackup");
> +        /// Remote.DatastoreModify allows to modify remote datastores
> +        PRIV_REMOTE_DATASTORE_MODIFY("Remote.DatastoreModify");
> +        /// Remote.DatastorePrune allows deleting snapshots on remote datastores
> +        PRIV_REMOTE_DATASTORE_PRUNE("Remote.DatastorePrune");
>  
>          /// Sys.Console allows access to the system's console
>          PRIV_SYS_CONSOLE("Sys.Console");
> @@ -160,6 +166,25 @@ pub const ROLE_REMOTE_SYNC_OPERATOR: u64 = 0
>      | PRIV_REMOTE_AUDIT
>      | PRIV_REMOTE_READ;
>  
> +#[rustfmt::skip]
> +#[allow(clippy::identity_op)]
> +/// Remote.SyncPushOperator can do read and push snapshots to the remote.
> +pub const ROLE_REMOTE_SYNC_PUSH_OPERATOR: u64 = 0
> +    | PRIV_REMOTE_AUDIT
> +    | PRIV_REMOTE_DATASTORE_BACKUP;
> +
> +#[rustfmt::skip]
> +#[allow(clippy::identity_op)]
> +/// Remote.DatastorePrune can prune owned snapshots and groups.
> +pub const ROLE_REMOTE_DATASTORE_PRUNE: u64 = 0
> +    | PRIV_REMOTE_DATASTORE_PRUNE;
> +
> +#[rustfmt::skip]
> +#[allow(clippy::identity_op)]
> +/// Remote.DatastoreModify can create and remove namespaces on the remote.
> +pub const ROLE_REMOTE_DATASTORE_MODIFY: u64 = 0
> +    | PRIV_REMOTE_DATASTORE_MODIFY;
> +
>  #[rustfmt::skip]
>  #[allow(clippy::identity_op)]
>  /// Tape.Audit can audit the tape backup configuration and media content
> @@ -225,6 +250,12 @@ pub enum Role {
>      RemoteAdmin = ROLE_REMOTE_ADMIN,
>      /// Synchronization Operator
>      RemoteSyncOperator = ROLE_REMOTE_SYNC_OPERATOR,
> +    /// Synchronisation Operator (push direction)
> +    RemoteSyncPushOperator = ROLE_REMOTE_SYNC_PUSH_OPERATOR,
> +    /// Remote Datastore Prune
> +    RemoteDatastorePrune = ROLE_REMOTE_DATASTORE_PRUNE,

should we name this role "RemoteDatastorePowerUser", to match the local role?

> +    /// Remote Datastore Modify
> +    RemoteDatastoreModify = ROLE_REMOTE_DATASTORE_MODIFY,

and this would then become RemoteDatastoreAdmin ? although that is not a 1:1
match, since DatastoreAdmin also includes verify, read, ..

naming the roles just after the privs might bite us down the line, if we ever
extend/split the privs..

>      /// Tape Auditor
>      TapeAudit = ROLE_TAPE_AUDIT,
>      /// Tape Administrator
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel