From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 285F81FF16E for ; Tue, 29 Oct 2024 11:52:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D9B3B34E03; Tue, 29 Oct 2024 11:52:05 +0100 (CET) MIME-Version: 1.0 In-Reply-To: <20241022142843.142191-1-f.schauer@proxmox.com> References: <20241022142843.142191-1-f.schauer@proxmox.com> From: Fabian =?utf-8?q?Gr=C3=BCnbichler?= To: Filip Schauer , pbs-devel@lists.proxmox.com Date: Tue, 29 Oct 2024 11:51:55 +0100 Message-ID: <173019911577.51916.12443633994358379874@yuna.proxmox.com> User-Agent: alot/0.10 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [vma2pbs.rs, proxmox.com, vma.rs, main.rs] Subject: Re: [pbs-devel] [PATCH vma-to-pbs v3 0/6] add support for bulk import of a dump directory X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" this is shaping up nicely, some comments on individual patches. I just bumped proxmox-backup-qemu and vma-to-pbs to use PBS 3.2.8-1, please rebase on top of that for subsequent versions. Quoting Filip Schauer (2024-10-22 16:28:37) > When a path to a directory is provided in the vma_file argument, try to > upload all VMA backups in the directory. This also handles compressed > VMA files, notes and logs. If a vmid is specified with --vmid, only the > backups of that particular vmid are uploaded. > > Also improve the readability of the log messages to keep track of all > imported backups. > > Changed since v2: > * Make skipping a VMID on error optional with the --skip-failed option > * Switch log output from stderr to stdout > * Bump itertools to 0.13 > > Changed since v1: > * Do not recurse through dump directory > * Compile regex once before iterating over the files in the dump > directory > * Use extract on regex capture groups > * Do not use deprecated method `chrono::NaiveDateTime::timestamp` > * Use proxmox_sys::fs::file_read_optional_string > * Group VMA files by VMID and continue with next VMID on error > * Move the BackupVmaToPbsArgs split into its own commit > * Remove hard coded occurences of 255 > * Use level-based logging instead of println > > Filip Schauer (6): > split BackupVmaToPbsArgs into PbsArgs and VmaBackupArgs > add support for bulk import of a dump directory > add option to skip vmids whose backups failed to upload > remove hard coded values > use level-based logging instead of println > log device upload progress as a percentage > > Cargo.toml | 5 + > src/main.rs | 156 ++++++++++++++++++++++--- > src/vma.rs | 2 +- > src/vma2pbs.rs | 312 ++++++++++++++++++++++++++++++++----------------- > 4 files changed, 354 insertions(+), 121 deletions(-) > > -- > 2.39.5 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel