From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id F188E1FF168 for ; Mon, 14 Oct 2024 15:41:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8834435EB6; Mon, 14 Oct 2024 15:42:26 +0200 (CEST) Date: Mon, 14 Oct 2024 15:42:19 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20240904141155.350454-1-h.laimer@proxmox.com> <20240904141155.350454-5-h.laimer@proxmox.com> In-Reply-To: <20240904141155.350454-5-h.laimer@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1728906958.5q0kxqaw2x.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v12 04/26] maintenance: add 'Unmount' maintenance type X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On September 4, 2024 4:11 pm, Hannes Laimer wrote: > From: Dietmar Maurer > > Signed-off-by: Hannes Laimer > Signed-off-by: Dietmar Maurer so is this a patch from Dietmar or (partially) from you? > --- > pbs-api-types/src/datastore.rs | 3 +++ > pbs-api-types/src/maintenance.rs | 5 ++++- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs > index 863ed317..d6e2f97e 100644 > --- a/pbs-api-types/src/datastore.rs > +++ b/pbs-api-types/src/datastore.rs > @@ -404,6 +404,9 @@ impl DataStoreConfig { > match current_type { > Some(MaintenanceType::ReadOnly) => { /* always OK */ } > Some(MaintenanceType::Offline) => { /* always OK */ } > + Some(MaintenanceType::Unmount) => { > + bail!("datastore is being unmounted"); > + } > Some(MaintenanceType::Delete) => { > match new_type { > Some(MaintenanceType::Delete) => { /* allow to delete a deleted storage */ } > diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs > index 1e3413dc..fd4d3416 100644 > --- a/pbs-api-types/src/maintenance.rs > +++ b/pbs-api-types/src/maintenance.rs > @@ -38,7 +38,6 @@ pub enum Operation { > /// Maintenance type. > pub enum MaintenanceType { > // TODO: > - // - Add "unmounting" once we got pluggable datastores > // - Add "GarbageCollection" or "DeleteOnly" as type and track GC (or all deletes) as separate > // operation, so that one can enable a mode where nothing new can be added but stuff can be > // cleaned > @@ -48,6 +47,8 @@ pub enum MaintenanceType { > Offline, > /// The datastore is being deleted. > Delete, > + /// The (removable) datastore is being unmounted. > + Unmount, > } > serde_plain::derive_display_from_serialize!(MaintenanceType); > serde_plain::derive_fromstr_from_deserialize!(MaintenanceType); > @@ -94,6 +95,8 @@ impl MaintenanceMode { > > if let Some(Operation::Lookup) = operation { > return Ok(()); > + } else if self.ty == MaintenanceType::Unmount { > + bail!("datastore is being unmounted"); > } else if self.ty == MaintenanceType::Offline { > bail!("offline maintenance mode: {}", message); > } else if self.ty == MaintenanceType::ReadOnly { > -- > 2.39.2 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel