From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 633201FF15C
	for <inbox@lore.proxmox.com>; Wed,  7 Aug 2024 12:45:35 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 7C49E4A78;
	Wed,  7 Aug 2024 12:45:44 +0200 (CEST)
MIME-Version: 1.0
In-Reply-To: <20240801074403.36229-14-c.ebner@proxmox.com>
References: <20240801074403.36229-1-c.ebner@proxmox.com>
 <20240801074403.36229-14-c.ebner@proxmox.com>
From: Fabian =?utf-8?q?Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>, pbs-devel@lists.proxmox.com
Date: Wed, 07 Aug 2024 12:45:35 +0200
Message-ID: <172302753518.107519.6330916068168411771@yuna.proxmox.com>
User-Agent: alot/0.10
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.050 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [proxmox.com, remote.read, acl.rs]
Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup 13/31] api types: define
 remote permissions and roles for push sync
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

Quoting Christian Ebner (2024-08-01 09:43:45)
> Adding the privileges to allow backup and prune on remote targets, to
> be used for sync jobs in push direction.
> 
> Also adds a dedicated role collecting the required privileges.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> changes since version 1:
> - no changes
> 
>  pbs-api-types/src/acl.rs | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/pbs-api-types/src/acl.rs b/pbs-api-types/src/acl.rs
> index ef6398629..f644029fa 100644
> --- a/pbs-api-types/src/acl.rs
> +++ b/pbs-api-types/src/acl.rs
> @@ -58,6 +58,12 @@ constnamedbitmap! {
>          PRIV_REMOTE_MODIFY("Remote.Modify");
>          /// Remote.Read allows reading data from a configured `Remote`
>          PRIV_REMOTE_READ("Remote.Read");
> +        /// Remote.Backup allows Remote.Read and creating new snapshots on a configured `Remote`,
> +        /// but also requires backup ownership
> +        PRIV_REMOTE_BACKUP("Remote.Backup");
> +        /// Remote.Prune allows deleting snapshots on a configured `Remote`,
> +        /// but also requires backup ownership
> +        PRIV_REMOTE_PRUNE("Remote.Prune");
>  
>          /// Sys.Console allows access to the system's console
>          PRIV_SYS_CONSOLE("Sys.Console");
> @@ -151,6 +157,7 @@ pub const ROLE_REMOTE_AUDIT: u64 = 0
>  pub const ROLE_REMOTE_ADMIN: u64 = 0
>      | PRIV_REMOTE_AUDIT
>      | PRIV_REMOTE_MODIFY
> +    | PRIV_REMOTE_BACKUP
>      | PRIV_REMOTE_READ;

according to the description of the role, this should also get PRIV_REMOTE_PRUNE?

>  
>  #[rustfmt::skip]
> @@ -160,6 +167,14 @@ pub const ROLE_REMOTE_SYNC_OPERATOR: u64 = 0
>      | PRIV_REMOTE_AUDIT
>      | PRIV_REMOTE_READ;

do we want to copy+rename this to make the "PULL" explicit, and deprecate the old name?

>  
> +#[rustfmt::skip]
> +#[allow(clippy::identity_op)]
> +/// Remote.SyncPushOperator can do read, backup and prune on the remote.
> +pub const ROLE_REMOTE_SYNC_PUSH_OPERATOR: u64 = 0
> +    | PRIV_REMOTE_AUDIT
> +    | PRIV_REMOTE_BACKUP
> +    | PRIV_REMOTE_READ;

shouldn't just BACKUP be enough here? that implies having access to owned backups..

> +
>  #[rustfmt::skip]
>  #[allow(clippy::identity_op)]
>  /// Tape.Audit can audit the tape backup configuration and media content
> @@ -225,6 +240,8 @@ pub enum Role {
>      RemoteAdmin = ROLE_REMOTE_ADMIN,
>      /// Syncronisation Opertator
>      RemoteSyncOperator = ROLE_REMOTE_SYNC_OPERATOR,
> +    /// Syncronisation Opertator (push direction)

typo: Opertator

pre-existing typo: Synchronisation

> +    RemoteSyncPushOperator = ROLE_REMOTE_SYNC_PUSH_OPERATOR,
>      /// Tape Auditor
>      TapeAudit = ROLE_TAPE_AUDIT,
>      /// Tape Administrator
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel