From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6D3501FF15C for <inbox@lore.proxmox.com>; Wed, 7 Aug 2024 11:39:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 636333773; Wed, 7 Aug 2024 11:39:42 +0200 (CEST) MIME-Version: 1.0 In-Reply-To: <20240722103034.343303-1-c.ebner@proxmox.com> References: <20240722103034.343303-1-c.ebner@proxmox.com> From: Fabian =?utf-8?q?Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com> To: Christian Ebner <c.ebner@proxmox.com>, pbs-devel@lists.proxmox.com Date: Wed, 07 Aug 2024 11:39:00 +0200 Message-ID: <172302354031.107519.4799945439534310954@yuna.proxmox.com> User-Agent: alot/0.10 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [catalog.rs, main.rs, proxmox.com, mod.rs] Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup 0/7] fix catalog dump and shell for split pxar archives X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> Quoting Christian Ebner (2024-07-22 12:30:27) > This patch series fixes the `catalog dump` and `catalog shell` > commands for snapshots created by setting the `change-detection-mode` > to either `data` or `metadata`, therefore using split pxar archive > encoding without encoding the dedicated catalog. > > If no catalog file can be found in the snaphsots manifest, the fallback > behaviour is now to check if there are metadata archives present in the > manifest, and if so use the metadata archive accessor for either > dumping the contents in a format compatible to the catalog dump or to > interactively navigate and restore contents via the catalog shell. some comments on individual patches, but one higher level one here: the new helpers are mostly used by the catalog shell and by eachother. I think it would make sense to find or create a more specific place than the catch-all pbs-client tools. the 'handle_root_with_optional_format_version_prelude' also seems a bit misplaced there and could maybe move closer to pxar related code as well? > > Changes since version 1: > - Implement also the `catalog shell` command for split pxar archives > - Factor out common functionality into dedicated helpers > > Christian Ebner (7): > client: make helper to get remote pxar reader reusable > client: tools: factor out entry path prefix helper > client: tools: factor out pxar entry to dir entry mapping > client: add helper to dump catalog from metadata archive > client: catalog: fallback to metadata archives for catalog dump > client: helper to mimic catalog find using metadata archive > client: catalog shell: fallback to accessor for navigation > > pbs-client/src/catalog_shell.rs | 303 ++++++++++++++++++++++----- > pbs-client/src/tools/mod.rs | 214 +++++++++++++++---- > proxmox-backup-client/src/catalog.rs | 65 +++++- > proxmox-file-restore/src/main.rs | 31 +-- > 4 files changed, 488 insertions(+), 125 deletions(-) > > -- > 2.39.2 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel