From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3500D1FF2AA for ; Wed, 3 Jul 2024 15:06:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D72D869F; Wed, 3 Jul 2024 15:06:31 +0200 (CEST) Date: Wed, 03 Jul 2024 15:06:24 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20240527130715.189131-1-f.schauer@proxmox.com> In-Reply-To: <20240527130715.189131-1-f.schauer@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1720011814.0592udjbmw.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH backup-qemu/vma-to-pbs 0/2] add support for notes and logs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On May 27, 2024 3:07 pm, Filip Schauer wrote: > Allow the user of vma-to-pbs to specify a notes file and a log file to > associate with the backup. > > proxmox-backup-qemu: > > Filip Schauer (1): > add support for notes I am not sure this is really warranted, especially since we don't want to keep using the proxmox-backup-qemu lib here in the long run anyway, but switch to a (to-be-extracted) pure Rust client directly.. as a stop-gap measure, couldn't we just use `proxmox-backup-client` to set the notes? > > src/backup.rs | 6 +++++- > src/lib.rs | 9 +++++++++ > 2 files changed, 14 insertions(+), 1 deletion(-) > > > vma-to-pbs: > > Filip Schauer (1): > add support for notes and logs and the log as well, since that is not really handled correctly right now anyway (the log is not a config file, there is a special command/API endpoint for uploading the log). > > src/main.rs | 16 +++++++++++++ > src/vma2pbs.rs | 64 ++++++++++++++++++++++++++++++++++++++++++-------- > 2 files changed, 70 insertions(+), 10 deletions(-) > > > Summary over all repositories: > 4 files changed, 84 insertions(+), 11 deletions(-) > > -- > Generated by git-murpp 0.6.0 > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel