From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C93BF1FF2B0 for ; Tue, 2 Jul 2024 10:44:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9A22518A12; Tue, 2 Jul 2024 10:44:46 +0200 (CEST) Date: Tue, 02 Jul 2024 10:44:09 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20240702072414.91159-1-c.ebner@proxmox.com> In-Reply-To: <20240702072414.91159-1-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1719909819.i0js1zzlug.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, mount.rs] Subject: [pbs-devel] applied: [PATCH proxmox-backup] close #5571: client: fix regression for `map` command X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" with Gabriel's T-b/R-b, and the commit reference reformatted into a proper "Fixes:" trailer. On July 2, 2024 9:24 am, Christian Ebner wrote: > Fixes a regression introduced by commit 08fe5052: > "client: mount: make split pxar archives mountable" > > This commit introduced functionality to mount split pxar archives > (sharing code with the map command), moving the manifest lookup > exclusive to fixed index archives. > However, the lookup now uses the incorrect archive name, not > containing the `.fidx` extension, which is however required for the > lookup in the manifest. > > Fix the issue by calling the method with the correct server archive > name including the required extension. > > Signed-off-by: Christian Ebner > --- > proxmox-backup-client/src/mount.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/proxmox-backup-client/src/mount.rs b/proxmox-backup-client/src/mount.rs > index d96690839..538a40e68 100644 > --- a/proxmox-backup-client/src/mount.rs > +++ b/proxmox-backup-client/src/mount.rs > @@ -302,7 +302,7 @@ async fn mount_do(param: Value, pipe: Option) -> Result { > } > } > } else if server_archive_name.ends_with(".fidx") { > - let file_info = manifest.lookup_file_info(archive_name)?; > + let file_info = manifest.lookup_file_info(&server_archive_name)?; > let index = client > .download_fixed_index(&manifest, &server_archive_name) > .await?; > -- > 2.39.2 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel