From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id EBC521FF396 for ; Thu, 6 Jun 2024 10:54:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 91358A2E6; Thu, 6 Jun 2024 10:55:00 +0200 (CEST) Date: Thu, 06 Jun 2024 10:54:54 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20240606081711.91531-1-c.ebner@proxmox.com> In-Reply-To: <20240606081711.91531-1-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1717664084.39cw3pfyah.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] applied: [PATCH proxmox-backup 0/2] conditionally skip pxar metadata reference test X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" thanks! On June 6, 2024 10:17 am, Christian Ebner wrote: > When running as user with uid/gid not equal to 1000/1000, the test to > create a pxar archive with previous metadata reference would fail, as > the created test directories and files do not get the expected ownership > set because of lack of permissions. > > Therefore these patches do: > - not even attempt to set the uid/gid for the folders, as without > permissions these are not set anyways. > - only execute the test on the condition that euid and egid are 1000 > > Tested by running the tests via: > `cargo test --workspace --release -- --nocapture` > > For root user and user with uid/gid 1000. Without the patches the test > fails for the root user, with the patches applied it passes for both. > > Christian Ebner (2): > client: pxar: do not attempt to set uid/gid in test > client: pxar: conditionally skip metadata reference test > > pbs-client/src/pxar/create.rs | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > -- > 2.39.2 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel