From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D88B31FF38F for ; Tue, 4 Jun 2024 10:39:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 514E6CF4A; Tue, 4 Jun 2024 10:40:19 +0200 (CEST) Date: Tue, 04 Jun 2024 10:39:43 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20240528094303.309806-1-c.ebner@proxmox.com> <20240528094303.309806-57-c.ebner@proxmox.com> In-Reply-To: <20240528094303.309806-57-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1717490174.hqijmdya09.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH v8 proxmox-backup 56/69] pxar: ignore version and prelude entries in listing X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On May 28, 2024 11:42 am, Christian Ebner wrote: > Do not list the pxar format version and the prelude entries in the > output of pxar list, these are not regular entries. I think it might still be nice to print at least the version in debugging mode? the prelude might be a bit hard, since it's an opaque blob of bytes, but we could also dump their existence/length or their base64- or hex-encoded contents? since patch #38 also adds the padding lines there, the output with level debug already contains lines which are not just the regular entry information.. > > Signed-off-by: Christian Ebner > --- > changes since version 7: > - no changes > > changes since version 6: > - not present > > pxar-bin/src/main.rs | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/pxar-bin/src/main.rs b/pxar-bin/src/main.rs > index 2cf8def53..69d948e73 100644 > --- a/pxar-bin/src/main.rs > +++ b/pxar-bin/src/main.rs > @@ -484,6 +484,7 @@ fn dump_archive(archive: String, payload_input: Option) -> Result<(), Er > > if log::log_enabled!(log::Level::Debug) { > match entry.kind() { > + EntryKind::Version(_) | EntryKind::Prelude(_) => continue, > EntryKind::File { > payload_offset: Some(offset), > size, > -- > 2.39.2 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel