From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 06D3D92998 for ; Mon, 8 Apr 2024 11:36:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D5A0576C8 for ; Mon, 8 Apr 2024 11:35:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 8 Apr 2024 11:35:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C96BD4458B for ; Mon, 8 Apr 2024 11:35:33 +0200 (CEST) Date: Mon, 08 Apr 2024 11:35:29 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20240405130543.259220-1-h.duerr@proxmox.com> <20240405130543.259220-4-h.duerr@proxmox.com> In-Reply-To: <20240405130543.259220-4-h.duerr@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1712568297.ngmgxkzot1.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 3/3] docs: add garbage collection timing example X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2024 09:36:06 -0000 On April 5, 2024 3:05 pm, Hannes Duerr wrote: > To make the garbage collection process easier to understand, we add a > timing example with a graphic. >=20 > Signed-off-by: Hannes Duerr > --- > docs/images/garbage-collection-timing.svg | 2513 +++++++++++++++++++++ > docs/maintenance.rst | 25 + > 2 files changed, 2538 insertions(+) > create mode 100644 docs/images/garbage-collection-timing.svg >=20 > diff --git a/docs/images/garbage-collection-timing.svg b/docs/images/garb= age-collection-timing.svg > new file mode 100644 > index 00000000..8108ee23 > --- /dev/null > +++ b/docs/images/garbage-collection-timing.svg [snip] > diff --git a/docs/maintenance.rst b/docs/maintenance.rst > index e25c8f19..a23e5c21 100644 > --- a/docs/maintenance.rst > +++ b/docs/maintenance.rst > @@ -233,6 +233,31 @@ by the GC as it cannot be certain whether they are s= till needed. > which is 24 hours by default. > =20 > =20 > +Timing Example > +^^^^^^^^^^^^^^ > + > +.. figure:: images/garbage-collection-timing.svg > + :class: proxmox-svg > + :alt: Garbage Collection timing > + > +t\ :sub:`0`\: > +All chunks are part of the backup indices. Some chunks have a newer > +``atime`` than the cut-off time, while others have not been accessed > +for a while (e.g. because they were only created by a new backup). > + > +t\ :sub:`1`\: > +A backup has been deleted and some chunks are no longer used > + > +t\ :sub:`2`\: > +The first phase of the GC begins and the ``atime`` of the chunks that > +are still being used by a backup are updated > + > +t\ :sub:`3`\: > +The second phase of the GC begins. Chunks that have not been used and > +whose ``atime`` is older than the cut-off time are deleted. Chunks that > +have not been used but whose ``atime`` is newer than the cut-off time > +are not yet deleted, but are marked as pending as a precaution. I think a visualization might help understand how GC, backup tasks and pruning interact. I am not sure this one is "it", though ;) Maybe changing the time to flow downwards would give more space in the horizontal axis to display indices and chunks at a certain point in time? At least for me, the arrangement of the chunks between the time markers throws me off.. > + > Manually Starting GC > ^^^^^^^^^^^^^^^^^^^^ > =20 > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 >=20