From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 546F892955 for ; Mon, 8 Apr 2024 11:05:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2E7486D8E for ; Mon, 8 Apr 2024 11:05:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 8 Apr 2024 11:05:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 20506444C8 for ; Mon, 8 Apr 2024 11:05:05 +0200 (CEST) Date: Mon, 08 Apr 2024 11:05:01 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20240328123707.336951-1-c.ebner@proxmox.com> <20240328123707.336951-19-c.ebner@proxmox.com> In-Reply-To: <20240328123707.336951-19-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1712566799.mmkgzxkrym.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH v3 proxmox-backup 18/58] client: backup: early check for fixed index type X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2024 09:05:39 -0000 same applies here - this makes sense even for the current code. On March 28, 2024 1:36 pm, Christian Ebner wrote: > Early return when the check fails, avoiding constuction of unused > object instances. >=20 > Signed-off-by: Christian Ebner > --- > changes since version 2: > - move to top of the function as intended >=20 > proxmox-backup-client/src/main.rs | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/sr= c/main.rs > index 74adf1b16..931c841c7 100644 > --- a/proxmox-backup-client/src/main.rs > +++ b/proxmox-backup-client/src/main.rs > @@ -192,6 +192,10 @@ async fn backup_directory>( > pxar_create_options: pbs_client::pxar::PxarCreateOptions, > upload_options: UploadOptions, > ) -> Result { > + if upload_options.fixed_size.is_some() { > + bail!("cannot backup directory with fixed chunk size!"); > + } > + > let pxar_stream =3D PxarBackupStream::open(dir_path.as_ref(), catalo= g, pxar_create_options)?; > let mut chunk_stream =3D ChunkStream::new(pxar_stream, chunk_size); > =20 > @@ -206,9 +210,6 @@ async fn backup_directory>( > } > }); > =20 > - if upload_options.fixed_size.is_some() { > - bail!("cannot backup directory with fixed chunk size!"); > - } > =20 > let stats =3D client > .upload_stream(archive_name, stream, upload_options) > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 >=20