From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AAB4D92281 for ; Fri, 5 Apr 2024 12:16:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 89EC411476 for ; Fri, 5 Apr 2024 12:16:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 5 Apr 2024 12:16:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C2D4C463B7 for ; Fri, 5 Apr 2024 12:16:51 +0200 (CEST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20240328123707.336951-55-c.ebner@proxmox.com> References: <20240328123707.336951-1-c.ebner@proxmox.com> <20240328123707.336951-55-c.ebner@proxmox.com> From: Fabian =?utf-8?q?Gr=C3=BCnbichler?= To: Christian Ebner , pbs-devel@lists.proxmox.com Date: Fri, 05 Apr 2024 12:16:45 +0200 Message-ID: <171231220563.1926770.17713102356320222919@yuna.proxmox.com> User-Agent: alot/0.10 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 54/58] client: pxar: add flow chart for metadata change detection X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Apr 2024 10:16:53 -0000 Quoting Christian Ebner (2024-03-28 13:37:03) > A high level flow chart describing the logic used for the metadata > based file change detection mode. >=20 > Signed-off-by: Christian Ebner > --- > changes since version 2: > - not present in previous version >=20 > ...ow-chart-metadata-based-file-change-detection.svg | 1 + > ...ow-chart-metadata-based-file-change-detection.txt | 12 ++++++++++++ > 2 files changed, 13 insertions(+) > create mode 100644 pbs-client/src/pxar/flow-chart-metadata-based-file-ch= ange-detection.svg > create mode 100644 pbs-client/src/pxar/flow-chart-metadata-based-file-ch= ange-detection.txt >=20 > diff --git a/pbs-client/src/pxar/flow-chart-metadata-based-file-change-de= tection.svg b/pbs-client/src/pxar/flow-chart-metadata-based-file-change-det= ection.svg > new file mode 100644 > index 000000000..5e6df4815 > --- /dev/null > +++ b/pbs-client/src/pxar/flow-chart-metadata-based-file-change-detection= .svg > @@ -0,0 +1 @@ [snip] something here got broken (I guess mail related somewhere along the way?). = it does work if the contents are manually merged backed into a single line bef= ore applying the patch though. in any case, it probably would be nice to have t= his autogenerated and moved to some part of the docs :) > diff --git a/pbs-client/src/pxar/flow-chart-metadata-based-file-change-de= tection.txt b/pbs-client/src/pxar/flow-chart-metadata-based-file-change-det= ection.txt > new file mode 100644 > index 000000000..5eace70be > --- /dev/null > +++ b/pbs-client/src/pxar/flow-chart-metadata-based-file-change-detection= .txt > @@ -0,0 +1,12 @@ > +flowchart TD > + A[Archiver] -->|lookup metadata| B[Accessor] > + B -->|is reusable entry| C[Lookahead Cache] > + C -->|lookup reusable chunks| D[Dynamic Index] > + D -->|insert and deduplicate dynamic entries| E[Reused Chunks] > + B -->|is not reusable entry| F(re-encode cached entries and current = entry) > + F -->|caching disabled| A > + E -->|padding above threshold, non-continuous chunks, caching disabl= ed| F > + E -->|padding above threshold, chunks continuous, caching enabled| A > + E -->|padding below threshold| G(force boundary, inject chunks, keep= back last chunk for potential followup) > + G -->|caching enabled| A the caching enabled/disabled parts here are probably confusing (do those ed= ges mean caching is enabled/disabled at that point? or are they taken if it is enabled/disabled?) but probably it makes sense to re-visit this in detail once the dust has se= ttled :) > + > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >