From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 97F6591864 for ; Thu, 4 Apr 2024 12:02:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7AF0E368EF for ; Thu, 4 Apr 2024 12:01:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 4 Apr 2024 12:01:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2BE5345222 for ; Thu, 4 Apr 2024 12:01:52 +0200 (CEST) Date: Thu, 04 Apr 2024 12:01:45 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20240328123707.336951-1-c.ebner@proxmox.com> <20240328123707.336951-32-c.ebner@proxmox.com> In-Reply-To: <20240328123707.336951-32-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1712224223.x1o1szdr2z.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 31/58] www: cover meta extension for pxar archives X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Apr 2024 10:02:23 -0000 On March 28, 2024 1:36 pm, Christian Ebner wrote: > Allows to access the pxar meta archives for navigation and download > via the Proxmox Backup Server web ui. >=20 > Signed-off-by: Christian Ebner > --- > changes since version 2: > - use mpxar and ppxar file extensions >=20 > www/datastore/Content.js | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/www/datastore/Content.js b/www/datastore/Content.js > index c2403ff9c..eb25f6ca4 100644 > --- a/www/datastore/Content.js > +++ b/www/datastore/Content.js > @@ -1050,7 +1050,7 @@ Ext.define('PBS.DataStoreContent', { > tooltip: gettext('Browse'), > getClass: (v, m, { data }) =3D> { > if ( > - (data.ty =3D=3D=3D 'file' && data.filename.endsWith('pxar.didx'))= || > + (data.ty =3D=3D=3D 'file' && (data.filename.endsWith('pxar.didx')= || data.filename.endsWith('mpxar.didx'))) || > (data.ty =3D=3D=3D 'ns' && !data.root) > ) { > return 'fa fa-folder-open-o'; > @@ -1058,7 +1058,9 @@ Ext.define('PBS.DataStoreContent', { > return 'pmx-hidden'; > }, > isActionDisabled: (v, r, c, i, { data }) =3D> > - !(data.ty =3D=3D=3D 'file' && data.filename.endsWith('pxar.didx') && = data['crypt-mode'] < 3) && data.ty !=3D=3D 'ns', > + !(data.ty =3D=3D=3D 'file' && > + (data.filename.endsWith('pxar.didx') || data.filename.endsWith('mpxar= .didx')) && > + data['crypt-mode'] < 3) && data.ty !=3D=3D 'ns', is this patch needed? the filename now always ends with pxar.didx (note the missing leading '.') ;) if we want to keep it and only make non-split archives and the meta archives browsable, then we need to add the '.' > }, > ], > }, > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 >=20