From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DFC96B906B for ; Tue, 12 Mar 2024 13:18:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B8DFC17487 for ; Tue, 12 Mar 2024 13:17:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 12 Mar 2024 13:17:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BDCFB427FE for ; Tue, 12 Mar 2024 13:17:42 +0100 (CET) Date: Tue, 12 Mar 2024 13:17:35 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20240305092703.126906-1-c.ebner@proxmox.com> <20240305092703.126906-32-c.ebner@proxmox.com> In-Reply-To: <20240305092703.126906-32-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1710245702.bw6ryqnajc.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pbs-devel] [RFC v2 proxmox-backup 31/36] specs: add backup detection mode specification X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2024 12:18:16 -0000 nit: this patch is ordered wrong in the series On March 5, 2024 10:26 am, Christian Ebner wrote: > Adds the specification for switching the detection mode used to > identify regular files which changed since a reference backup run. >=20 > Rather than being a flag selecting the mode, it is possible to pass > a list of archives for which to use metadata base file change > detection, allowing to run mixed modes with the same client > invocation. >=20 > Signed-off-by: Christian Ebner > --- > changes since version 1: > - no changes >=20 > pbs-client/src/backup_specification.rs | 53 ++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) >=20 > diff --git a/pbs-client/src/backup_specification.rs b/pbs-client/src/back= up_specification.rs > index 619a3a9d..5b33b451 100644 > --- a/pbs-client/src/backup_specification.rs > +++ b/pbs-client/src/backup_specification.rs > @@ -4,6 +4,7 @@ use proxmox_schema::*; > =20 > const_regex! { > BACKUPSPEC_REGEX =3D r"^([a-zA-Z0-9_-]+\.(pxar|img|conf|log)):(.+)$"= ; > + DETECTION_MODE_REGEX =3D r"^(data|metadata(:[a-zA-Z0-9_-]+\.pxar)*)$= "; > } > =20 > pub const BACKUP_SOURCE_SCHEMA: Schema =3D > @@ -11,6 +12,11 @@ pub const BACKUP_SOURCE_SCHEMA: Schema =3D > .format(&ApiStringFormat::Pattern(&BACKUPSPEC_REGEX)) > .schema(); > =20 > +pub const BACKUP_DETECTION_MODE_SPEC: Schema =3D > + StringSchema::new("Backup source specification ([data|metadata(:,...)]).") > + .format(&ApiStringFormat::Pattern(&DETECTION_MODE_REGEX)) > + .schema(); > + > pub enum BackupSpecificationType { > PXAR, > IMAGE, > @@ -45,3 +51,50 @@ pub fn parse_backup_specification(value: &str) -> Resu= lt =20 > bail!("unable to parse backup source specification '{}'", value); > } > + > +/// Mode to detect file changes since last backup run > +pub enum BackupDetectionMode { > + /// Regular mode, re-encode payload data > + Data, > + /// Compare metadata, reuse payload chunks if metadata unchanged > + /// > + /// Stores archive names for which to use the metadata mode > + Metadata(Vec), I already had this question in the other patch that uses this, but do we need this kind of control? wouldn't a third value MetadataNoReuse (name tbd ;)) to force a "cut" be enough (e.g., if I am either afraid that the re-use might have bugs, or I want to reset the re-use / chunk boundaries)? > +} > + > +impl BackupDetectionMode { > + /// Check if the selected mode is metadata based file change detecti= on > + pub fn is_metadata(&self) -> bool { > + match self { > + Self::Data =3D> false, > + Self::Metadata(_) =3D> true, > + } > + } > + > + /// List of archive names, for which metadata based file change dete= ction should be used > + pub fn metadata_archive_names(&self) -> &[String] { > + match self { > + Self::Data =3D> &[], > + Self::Metadata(ref archives) =3D> archives, > + } > + } > +} > + > +pub fn parse_backup_detection_mode_specification( > + value: &str, > +) -> Result { > + match (DETECTION_MODE_REGEX.regex_obj)().captures(value) { > + Some(caps) =3D> { > + let mode =3D match caps.get(1).unwrap().as_str() { > + "data" =3D> BackupDetectionMode::Data, > + ty if ty.starts_with("metadata") =3D> { > + let archives =3D ty.split(':').skip(1).map(|s| s.to_= string()).collect(); > + BackupDetectionMode::Metadata(archives) > + } > + _ =3D> bail!("invalid backup detection mode"), > + }; > + Ok(mode) > + } > + None =3D> bail!("unable to parse backup detection mode specifica= tion '{value}'"), > + } > +} > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 >=20