From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 04B4DB8C5C for ; Mon, 11 Mar 2024 15:57:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E1EEEB654 for ; Mon, 11 Mar 2024 15:57:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 11 Mar 2024 15:57:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3D8D648906 for ; Mon, 11 Mar 2024 15:57:38 +0100 (CET) Date: Mon, 11 Mar 2024 15:57:31 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20240305092703.126906-1-c.ebner@proxmox.com> <20240305092703.126906-14-c.ebner@proxmox.com> In-Reply-To: <20240305092703.126906-14-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1710163902.ikujo1xdmk.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.066 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [RFC v2 proxmox-backup 13/36] client: backup: early check for fixed index type X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2024 14:57:40 -0000 On March 5, 2024 10:26 am, Christian Ebner wrote: > Early return when the check fails, avoiding constuction of unused > object instances. >=20 > Signed-off-by: Christian Ebner > --- > changes since version 1: > - no changes >=20 > proxmox-backup-client/src/main.rs | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/sr= c/main.rs > index e3445b7b..256080be 100644 > --- a/proxmox-backup-client/src/main.rs > +++ b/proxmox-backup-client/src/main.rs > @@ -194,6 +194,9 @@ async fn backup_directory>( > ) -> Result { > let pxar_stream =3D PxarBackupStream::open(dir_path.as_ref(), catalo= g, pxar_create_options)?; > let mut chunk_stream =3D ChunkStream::new(pxar_stream, chunk_size); > + if upload_options.fixed_size.is_some() { > + bail!("cannot backup directory with fixed chunk size!"); > + } nit: while we're at it - why not do it first thing here before creating the streams? it does happen piece by piece later in the series, but could just happen here already. > =20 > let (tx, rx) =3D mpsc::channel(10); // allow to buffer 10 chunks > =20 > @@ -206,9 +209,6 @@ async fn backup_directory>( > } > }); > =20 > - if upload_options.fixed_size.is_some() { > - bail!("cannot backup directory with fixed chunk size!"); > - } > =20 > let stats =3D client > .upload_stream(archive_name, stream, upload_options) > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 >=20