From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E142790EE3 for ; Tue, 13 Feb 2024 11:31:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C118E345CF for ; Tue, 13 Feb 2024 11:30:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 13 Feb 2024 11:30:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1E5BD47B89 for ; Tue, 13 Feb 2024 11:30:55 +0100 (CET) Date: Tue, 13 Feb 2024 11:30:48 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20240213095320.186188-1-m.sandoval@proxmox.com> In-Reply-To: <20240213095320.186188-1-m.sandoval@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1707820232.u0iuqkntmn.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 1 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy FSL_BULK_SIG 0.001 Bulk signature with no Unsubscribe KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RAZOR2_CF_RANGE_51_100 1.886 Razor2 gives confidence level above 50% RAZOR2_CHECK 0.922 Listed in Razor2 (http://razor.sf.net/) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [185.199.111.153, 185.199.110.153, 185.199.108.153, 185.199.109.153] Subject: [pbs-devel] partially-applied: [PATCH backup 1/4] disks: remove useless conversion to the same type X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2024 10:31:26 -0000 applied 1 and 3, comments for 2 and 4 sent as well.. On February 13, 2024 10:53 am, Maximiliano Sandoval wrote: > Fixes the clippy lint: >=20 > ``` > warning: useless conversion to the same type: `std::ffi::OsString` > --> src/tools/disks/mod.rs:1161:9 > | > 1161 | count_str.into(), > | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `count= _str` > | > =3D help: for further information visit https://rust-lang.github.io/= rust-clippy/master/index.html#useless_conversion > ``` >=20 > Signed-off-by: Maximiliano Sandoval > --- > This patch series contains the missing patches from my "last" clippy patc= h series. >=20 > src/tools/disks/mod.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/src/tools/disks/mod.rs b/src/tools/disks/mod.rs > index 78360b66..94f89e0a 100644 > --- a/src/tools/disks/mod.rs > +++ b/src/tools/disks/mod.rs > @@ -1158,7 +1158,7 @@ pub fn wipe_blockdev(disk: &Disk, worker: Arc) -> Result<(), Error> > of_path, > "bs=3D1M".into(), > "conv=3Dfdatasync".into(), > - count_str.into(), > + count_str, > ]; > dd_command.args(args); > =20 > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 >=20