From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E397A90DDB for ; Tue, 13 Feb 2024 10:28:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BE2C4335C0 for ; Tue, 13 Feb 2024 10:28:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 13 Feb 2024 10:28:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CF2D147B84 for ; Tue, 13 Feb 2024 10:28:19 +0100 (CET) Date: Tue, 13 Feb 2024 10:28:13 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Maximiliano Sandoval , Proxmox Backup Server development discussion References: <20240212131734.454966-1-m.sandoval@proxmox.com> In-Reply-To: MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1707816332.wcbrq5ngpq.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs, proxmox.com, acl.rs] Subject: [pbs-devel] partially-applied: [PATCH backup 01/13] docs: remove redundant explicit link target X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2024 09:28:50 -0000 applied all (sent ;)) patches except #8, see comment there. On February 13, 2024 10:04 am, Maximiliano Sandoval wrote: >=20 > I somehow managed to not send the entire series, I'll send a new one =F0= =9F=99=8A. >=20 > Days since last email incident: 0. >=20 > Maximiliano Sandoval writes: >=20 >> Fixes: >> >> ``` >> warning: redundant explicit link target >> --> src/tools/mod.rs:47:42 >> | >> 47 | /// Returns a new instance of [`Client`](proxmox_http::client::Clie= nt) configured for PBS usage. >> | -------- ^^^^^^^^^^^^^^^^^^^^^^^^^^= ^^ explicit target is redundant >> | | >> | because label contains path that res= olves to same destination >> | >> =3D note: when a link's destination is not specified, >> the label is used to resolve intra-doc links >> =3D note: `#[warn(rustdoc::redundant_explicit_links)]` on by default >> help: remove explicit link target >> | >> 47 | /// Returns a new instance of [`Client`] configured for PBS usage. >> | ~~~~~~~~~~ >> ``` >> >> Signed-off-by: Maximiliano Sandoval >> --- >> pbs-config/src/acl.rs | 2 +- >> src/tools/mod.rs | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/pbs-config/src/acl.rs b/pbs-config/src/acl.rs >> index 20269f5d..cd9987fa 100644 >> --- a/pbs-config/src/acl.rs >> +++ b/pbs-config/src/acl.rs >> @@ -198,7 +198,7 @@ impl AclTreeNode { >> } >> >> /// Returns applicable [Role] and their propagation status for a gi= ven >> - /// [Authid](pbs_api_types::Authid). >> + /// [Authid]. >> /// >> /// If the `Authid` is a [User](pbs_api_types::User) that has no sp= ecific `Roles` configured on >> /// this node, applicable `Group` roles will be returned instead. >> diff --git a/src/tools/mod.rs b/src/tools/mod.rs >> index b6cc5448..f8c4f2d5 100644 >> --- a/src/tools/mod.rs >> +++ b/src/tools/mod.rs >> @@ -44,7 +44,7 @@ pub fn detect_modified_configuration_file( >> pub const PROXMOX_BACKUP_TCP_KEEPALIVE_TIME: u32 =3D 120; >> pub const DEFAULT_USER_AGENT_STRING: &str =3D "proxmox-backup-client/1.= 0"; >> >> -/// Returns a new instance of [`Client`](proxmox_http::client::Client) = configured for PBS usage. >> +/// Returns a new instance of [`Client`] configured for PBS usage. >> pub fn pbs_simple_http(proxy_config: Option) -> Client { >> let options =3D HttpOptions { >> proxy_config, >=20 >=20 > -- > Maximiliano >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20