From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9071ABFBCA for ; Tue, 9 Jan 2024 09:11:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 712EE141F9 for ; Tue, 9 Jan 2024 09:11:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 9 Jan 2024 09:11:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4D4404902C for ; Tue, 9 Jan 2024 09:11:23 +0100 (CET) Date: Tue, 09 Jan 2024 09:11:16 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20231129145116.202049-1-s.sterz@proxmox.com> In-Reply-To: <20231129145116.202049-1-s.sterz@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1704787813.92t0pk0mbb.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-offline-mirror-helper.rs, config.rs, proxmox.com, types.rs, proxmox-offline-mirror.rs, medium.rs, subscription.rs] Subject: [pbs-devel] applied: [PATCH proxmox-offline-mirror v2 0/3] improve pom multi-key handling X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2024 08:11:24 -0000 FWIW, this got applied back in December by Thomas :) On November 29, 2023 3:51 pm, Stefan Sterz wrote: > this patch series intends to improve the user experience when a user > adds multiple keys to one mirror and wants to use one medium to activate > multiple products. the first commit removes the `ProductType` trait that > has been moved to `proxmox-subscription` from pom. the second commit > handles media with muliple keys for muliple products more gracefully in > proxmox-offline-mirror-helper. it only tries to activate subscriptions > that have a matching server id. the finally commit just adds some > rustfmt clean ups. >=20 > changes since v1 @ (thanks to Fabian Gr=C3=BCnbichler): >=20 > - moved to a hash map based approach when automatically selecting all > applicable keys for the current system >=20 >=20 > Stefan Sterz (3): > type: move `ProductType` enum to `proxmox-subscription` > helper: improve handling of multiple keys when activating them > offline mirror binary: rustfmt clean up >=20 > src/bin/proxmox-offline-mirror-helper.rs | 101 ++++++++++-------- > src/bin/proxmox-offline-mirror.rs | 15 ++- > src/bin/proxmox_offline_mirror_cmds/medium.rs | 4 +- > .../subscription.rs | 4 +- > src/config.rs | 4 +- > src/subscription.rs | 4 +- > src/types.rs | 44 +------- > 7 files changed, 75 insertions(+), 101 deletions(-) >=20 > -- > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20