From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C0192B3B78 for ; Wed, 29 Nov 2023 14:28:15 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A0FF279B9 for ; Wed, 29 Nov 2023 14:27:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 29 Nov 2023 14:27:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BEC0F408B9 for ; Wed, 29 Nov 2023 14:27:44 +0100 (CET) Date: Wed, 29 Nov 2023 14:27:27 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20231129113637.204053-1-c.ebner@proxmox.com> <20231129113637.204053-3-c.ebner@proxmox.com> In-Reply-To: <20231129113637.204053-3-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1701264012.iyam5az1x7.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] api: create default garbage collection schedule X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2023 13:28:15 -0000 one nit below, but the same general remark as with patch #1 applies here as well.. On November 29, 2023 12:36 pm, Christian Ebner wrote: > Create a default garbage collection schedule when a datastore is created > as part of a disk/zpool creation transaction via e.g. > `proxmox-backup-manager disk fs create --disk > --add-datastore true` >=20 > Signed-off-by: Christian Ebner > --- > src/api2/node/disks/directory.rs | 5 +++-- > src/api2/node/disks/zfs.rs | 5 +++-- > 2 files changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git a/src/api2/node/disks/directory.rs b/src/api2/node/disks/direc= tory.rs > index 89260b8e..a3e1ba71 100644 > --- a/src/api2/node/disks/directory.rs > +++ b/src/api2/node/disks/directory.rs > @@ -196,8 +196,9 @@ pub fn create_datastore_disk( > =20 > if add_datastore { > let lock =3D pbs_config::datastore::lock_config()?; > - let datastore: DataStoreConfig =3D > - serde_json::from_value(json!({ "name": name, "path":= mount_point }))?; > + let datastore: DataStoreConfig =3D serde_json::from_valu= e( > + json!({ "name": name, "path": mount_point, "gc-sched= ule": String::from("daily") }), > + )?; > =20 > let (config, _digest) =3D pbs_config::datastore::config(= )?; > =20 > diff --git a/src/api2/node/disks/zfs.rs b/src/api2/node/disks/zfs.rs > index 7bc46986..7b8a3891 100644 > --- a/src/api2/node/disks/zfs.rs > +++ b/src/api2/node/disks/zfs.rs > @@ -311,8 +311,9 @@ pub fn create_zpool( > =20 > if add_datastore { > let lock =3D pbs_config::datastore::lock_config()?; > - let datastore: DataStoreConfig =3D > - serde_json::from_value(json!({ "name": name, "path":= mount_point }))?; > + let datastore: DataStoreConfig =3D serde_json::from_valu= e( > + json!({ "name": name, "path": mount_point, "gc-scheu= dle": String::from("daily") }), typo: s/scheudle/schedule > + )?; > =20 > let (config, _digest) =3D pbs_config::datastore::config(= )?; > =20 > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 >=20