From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 711349E211 for ; Mon, 27 Nov 2023 10:53:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 59A9F3AD4 for ; Mon, 27 Nov 2023 10:53:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 27 Nov 2023 10:53:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 324A644A4B for ; Mon, 27 Nov 2023 10:53:35 +0100 (CET) Date: Mon, 27 Nov 2023 10:53:27 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20230629103213.1041236-1-f.gruenbichler@proxmox.com> In-Reply-To: <20230629103213.1041236-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1701078797.6mini5i5t7.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup] mapped loop device: use read loop instead of read_exact X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Nov 2023 09:53:36 -0000 ping, still applies.. On June 29, 2023 12:32 pm, Fabian Gr=C3=BCnbichler wrote: > since read_exact does not support short reads, which can easily happen if= the > mapped image's EOF is not aligned with the request size. >=20 > Signed-off-by: Fabian Gr=C3=BCnbichler > --- >=20 > Notes: > reported on the forum: > =20 > https://forum.proxmox.com/threads/problem-backing-up-using-backup-cli= ent.129347 > =20 > did a quick test reading from a mapped image full of random data, obs= erved > no performance difference.. >=20 > pbs-fuse-loop/src/fuse_loop.rs | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) >=20 > diff --git a/pbs-fuse-loop/src/fuse_loop.rs b/pbs-fuse-loop/src/fuse_loop= .rs > index 3d0ef123..7e780799 100644 > --- a/pbs-fuse-loop/src/fuse_loop.rs > +++ b/pbs-fuse-loop/src/fuse_loop.rs > @@ -188,13 +188,20 @@ impl FuseLoopSess= ion { > match self.reader.seek(SeekFrom::Start(req.o= ffset)).await { > Ok(_) =3D> { > let mut buf =3D vec![0u8; req.size]; > - match self.reader.read_exact(&mut bu= f).await { > - Ok(_) =3D> { > - req.reply(&buf) > - }, > - Err(e) =3D> { > - req.io_fail(e) > + let mut read =3D 0; > + let mut res =3D Ok(()); > + while read < req.size && res.is_ok()= { > + match self.reader.read(&mut buf)= .await { > + Ok(0) =3D> { break; }, > + Ok(n) =3D> { read +=3D n; }, > + Err(e) =3D> { res =3D Err(e)= ; }, > } > + }; > + if let Err(e) =3D res { > + req.io_fail(e) > + } else { > + buf.truncate(read); > + req.reply(&buf) > } > }, > Err(e) =3D> { > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20