From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7FF31D386 for ; Wed, 30 Nov 2022 15:26:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 616541EA83 for ; Wed, 30 Nov 2022 15:26:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 30 Nov 2022 15:26:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 145F743E13; Wed, 30 Nov 2022 15:26:12 +0100 (CET) Message-ID: <16d7b3cb-7887-58c9-6514-9fc18400a78e@proxmox.com> Date: Wed, 30 Nov 2022 15:26:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:108.0) Gecko/20100101 Thunderbird/108.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Stefan Sterz References: <20221129164019.1193392-1-s.sterz@proxmox.com> From: Dominik Csapak In-Reply-To: <20221129164019.1193392-1-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.193 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.258 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] email_notifications: make html template more valid X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2022 14:26:43 -0000 some thoughts: i don't think 'more valid' is possible, either the markup is valid or not On 11/29/22 17:40, Stefan Sterz wrote: > some webmail interfaces may behave unexpectedly if the html is > invalid. thus, close tags and declare a language. which webmail interfaces? and according to whom is the old invalid and the new valid? i checked the html spec of the whatwg[0] and it seems to me that empty tags ('head' too) can be omitted also the 'lang' attribute is only recommended, not required the correct closing of the tags good though 0: https://html.spec.whatwg.org/multipage/semantics.html > > Signed-off-by: Stefan Sterz > --- > src/server/email_notifications.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/server/email_notifications.rs b/src/server/email_notifications.rs > index b3298cf9..378e805e 100644 > --- a/src/server/email_notifications.rs > +++ b/src/server/email_notifications.rs > @@ -294,7 +294,7 @@ fn send_job_status_mail(email: &str, subject: &str, text: &str) -> Result<(), Er > // Note: OX has serious problems displaying text mails, > // so we include html as well > let html = format!( > - "
\n{}\n
",
> +        "
\n{}\n
",
>           handlebars::html_escape(text)
>       );
>