From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A02CE642DF for ; Tue, 6 Oct 2020 12:22:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 92A4B244A3 for ; Tue, 6 Oct 2020 12:22:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EA3C524499 for ; Tue, 6 Oct 2020 12:22:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B05B44550A for ; Tue, 6 Oct 2020 12:22:04 +0200 (CEST) To: Proxmox Backup Server development discussion , =?UTF-8?Q?Dominic_J=c3=a4ger?= References: <20201006101000.70009-1-d.jaeger@proxmox.com> From: Thomas Lamprecht Message-ID: <169ffc35-5c08-8634-396e-7877c17acfa8@proxmox.com> Date: Tue, 6 Oct 2020 12:22:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20201006101000.70009-1-d.jaeger@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.147 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] Close #3058: ui: RemoteEdit: Add empty texts X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2020 10:22:05 -0000 Thanks for trying to improve user experience, I always appreciate that. But, we normally use emptyText for defaults, or at least make it very clear that they are not, if used as hint. You may want to switch those over to tooltips with more complete sentences. some more comments inline On 06.10.20 12:10, Dominic J=C3=A4ger wrote: > Signed-off-by: Dominic J=C3=A4ger > --- > www/window/RemoteEdit.js | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/www/window/RemoteEdit.js b/www/window/RemoteEdit.js > index 56a248e0..695ad422 100644 > --- a/www/window/RemoteEdit.js > +++ b/www/window/RemoteEdit.js > @@ -24,7 +24,7 @@ Ext.define('PBS.window.RemoteEdit', { > me.method =3D name ? 'PUT' : 'POST'; > me.autoLoad =3D !!name; > return { > - passwordEmptyText: me.isCreate ? '' : gettext('Unchanged'), > + passwordEmptyText: me.isCreate ? '=E2=80=A2'.repeat(16) : gettext= ('Unchanged'), > }; > }, > =20 > @@ -35,6 +35,7 @@ Ext.define('PBS.window.RemoteEdit', { > xtype: 'pmxDisplayEditField', > name: 'name', > fieldLabel: gettext('Remote'), > + emptyText: 'new_remote', Suggests that this is the default, makes no sense IMO. maybe add a "The unique ID for this remote" as tooltip and/or change the fieldLabel to 'ID' instead. > renderer: Ext.htmlEncode, > allowBlank: false, > minLength: 4, > @@ -49,6 +50,7 @@ Ext.define('PBS.window.RemoteEdit', { > submitValue: false, > vtype: 'HostPort', > fieldLabel: gettext('Host'), > + emptyText: '192.168.10.10', This suggests we use that IP as default, rather use a descriptive hint. If it's long, then it could be also added as tooltip instead, which job is to explain context better. Could also change fieldLabel to 'Remote Address' > listeners: { > change: function(field, newvalue) { > let host =3D newvalue; > @@ -95,6 +97,7 @@ Ext.define('PBS.window.RemoteEdit', { > allowBlank: false, > name: 'userid', > fieldLabel: gettext('Userid'), > + emptyText: 'root@pam', Is this the default? As else it is wrong to show as such, if we do this then we normally use something like "E.g., root@pam" or "For example, roo= t@pam" to indicate that this is not the default but a hint. A tooltip could work= better also here. > }, > { > xtype: 'textfield', > @@ -116,6 +119,7 @@ Ext.define('PBS.window.RemoteEdit', { > deleteEmpty: '{!isCreate}', > }, > fieldLabel: gettext('Fingerprint'), > + emptyText: '0f:04:9a:2d:48:23:52:5d:d5:f4:1d:9e:5d:37:8e:60:93:d8:b0= :03:31:8c:5c:d5:49:ff:96:31:9e:c2:1d:74', no, why would yo u use a real FP here? Rather something which indicates w= hat we expect here but does not suggests a default.. "ab:cd:ef:..." or like we do in the PVE "Add PBS" storage addition dialog. > }, > { > xtype: 'proxmoxtextfield', > @@ -124,6 +128,7 @@ Ext.define('PBS.window.RemoteEdit', { > deleteEmpty: '{!isCreate}', > }, > fieldLabel: gettext('Comment'), > + emptyText: gettext('A very long comment'), > }, > ], > }, >=20